homalg-project / homalg_project

Deposited packages of the homalg project
12 stars 19 forks source link

ReducedSyzygiesOfRows/Columns now calls BasisOfRow/ColumnModule #595

Closed mohamed-barakat closed 1 year ago

mohamed-barakat commented 1 year ago

before calling ReducedBasisOfRow/ColumnModule

zickgraf commented 1 year ago

Out of interest: How does this relate to https://github.com/homalg-project/homalg_project/pull/592?

mohamed-barakat commented 1 year ago

Out of interest: How does this relate to #592?

PR #592 was meant to make the interface to Singular finer, by preventing the composition of two operations in Singular. Now that we have that I indeed want the composition of these two operations on a higher level.

codecov[bot] commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Files Coverage Δ
ExamplesForHomalg/PackageInfo.g 100.00% <100.00%> (ø)
ExamplesForHomalg/examples/ExtExt.g 100.00% <ø> (ø)
...esForHomalg/examples/Hom(Hom(-,Z128),Z16)_On_Seq.g 100.00% <ø> (ø)
ExamplesForHomalg/examples/TorExt.g 100.00% <ø> (ø)
GaussForHomalg/PackageInfo.g 100.00% <100.00%> (ø)
MatricesForHomalg/PackageInfo.g 100.00% <100.00%> (ø)
MatricesForHomalg/gap/Basic.gi 84.30% <100.00%> (ø)
Modules/PackageInfo.g 100.00% <100.00%> (ø)
Modules/gap/BasicFunctors.gi 91.37% <ø> (ø)

... and 3 files with indirect coverage changes

:loudspeaker: Thoughts on this report? Let us know!.

zickgraf commented 1 year ago

Ah, I see, thanks!

mohamed-barakat commented 1 year ago

CI on Jenkins was failing. I had to make an adjustment in the package Sheaves.