search

home-assistant-ecosystem / home-assistant-cli

:computer: Command-line tool for Home Assistant
Other
446 stars 69 forks source link

Fix for examples regarding "--columns" to make examples work (at leas… #305

Closed haakonstorm closed 5 years ago

haakonstorm commented 5 years ago

Fix for examples regarding --columns to make examples work (at least for --output table which I've been testing! )

homeassistant commented 5 years ago

Hi @haakonstorm,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

codecov-io commented 5 years ago

Codecov Report

Merging #305 into dev will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #305   +/-   ##
=======================================
  Coverage   75.25%   75.25%           
=======================================
  Files          22       22           
  Lines        1560     1560           
=======================================
  Hits         1174     1174           
  Misses        386      386
Impacted Files Coverage Δ
homeassistant_cli/cli.py 76.13% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fa918dd...58fb680. Read the comment docs.

maxandersen commented 5 years ago

sorry for late response but the fix is only partially right.

Yes, entity_name should be entity_id but attributes.friendly_name is still what is there when using hass-cli state list, its only for hass-cli entity list its name.

maxandersen commented 5 years ago

merged but with fix that make it still use friendly_name.