home-assistant-ecosystem / home-assistant-cli

:computer: Command-line tool for Home Assistant
Other
428 stars 63 forks source link

fix(completions): convert to click@8 and update docs #369

Closed lwille closed 2 years ago

lwille commented 2 years ago

addresses #367

click greatly reworked their completions in pallets/click#1484 and pallets/click#1622. In consequence, click doesn't add an autocomplete command any more, so I've adjusted the shell snippets required to register completions.

I've also noticed that #143 is obsolete, as click fully supports fish: fixes #143

fzimmermann89 commented 2 years ago

Are you still working on this?

lwille commented 2 years ago

I gave up on this; closing the PR.

stratakis commented 2 years ago

I've tested this patch on the Fedora rpm and it fixes the test failures that sprouted from the latest click version (8.1.2). More specifically it addresses the TypeError: Parameter.__init__() got an unexpected keyword argument 'autocompletion'error. Not sure if there are other issues regarding the behavior change.