home-assistant-libs / netdisco

:mag_right: Python library to scan local network for services and devices.
Other
268 stars 147 forks source link

Separate DLNA_DMR and DLNA_DMS devices #204

Closed StevenLooman closed 6 years ago

StevenLooman commented 6 years ago

The DLNA standard specifies four device types (see the Wikipedia page on DLNA):

At this moment netdisco discovers DMS and DMR devices as one, named DLNA. Currently, Home Assistant is - as far as I know - only interested in DMR devices (as per https://github.com/home-assistant/home-assistant/pull/14749). The component in home-assistant now needs to detect if the device is a DMR device.

If these device types are separated, home-assistant becomes less 'polluted' with checks for proper device types. Also, introducing a DMS component to home-assistant would not work with discovery, as the DLNA_DMR component already 'catches' the DLNA discoveries.

Also, there are 4 DMS and 3 DMR versions. Currently only version 1 of both is discovered. This pull request makes netdisco support the other versions.

Please do inform me before merging (and releasing) this! The DLNA_DMR component in home-assistant + discovery has to be updated as well.

balloob commented 6 years ago

Thanks!

ok to merge when lint addressed and PR for Home Assistant created 👍

balloob commented 6 years ago

Released as netdisco 2.0.0