Fix known_hosts for older chromecasts

domenipavec commented 9 months ago

Older chromecasts (for example my Nvidia Shield TV) don't support secure /setup/eureka_info endpoint. That's why they don't get detected with known_hosts option in current implementation. There are several issues related to that (e.g. https://github.com/home-assistant-libs/pychromecast/issues/611)

This PR does the following:

When secure=None in _get_status it first tries secure request, if that times out or returns an error, it falls back to insecure. This codepath is only used in get_device_info
In discovery HostBrowser propagates appropriate timeout to get_device_info, so there is enough time to try all specified known_hosts.

emontnemery commented 9 months ago

@domenipavec can you confirm you have tested your changes both with your Nvidia Shield TV and with some device which does support secure /setup/eureka_info endpoint? Also, can you please fix the lint errors so CI passes. I strongly recommend to run the linters locally since I have to approve CI since this is your first PR.

domenipavec commented 9 months ago

@emontnemery Yes, this has been tested both with Nvidia Shield TV that uses insecure endpoint and with Google Home Mini and Chromecast with Google TV that use secure endpoint.

Lint errors should be fixed now.

domenipavec commented 9 months ago

@emontnemery When can we expect a new release with this changes?

home-assistant-libs / pychromecast

Fix known_hosts for older chromecasts #762