Closed domenipavec closed 9 months ago
@domenipavec can you confirm you have tested your changes both with your Nvidia Shield TV and with some device which does support secure /setup/eureka_info
endpoint?
Also, can you please fix the lint errors so CI passes. I strongly recommend to run the linters locally since I have to approve CI since this is your first PR.
@emontnemery Yes, this has been tested both with Nvidia Shield TV that uses insecure endpoint and with Google Home Mini and Chromecast with Google TV that use secure endpoint.
Lint errors should be fixed now.
@emontnemery When can we expect a new release with this changes?
Older chromecasts (for example my Nvidia Shield TV) don't support secure
/setup/eureka_info
endpoint. That's why they don't get detected withknown_hosts
option in current implementation. There are several issues related to that (e.g. https://github.com/home-assistant-libs/pychromecast/issues/611)This PR does the following:
secure=None
in_get_status
it first tries secure request, if that times out or returns an error, it falls back to insecure. This codepath is only used inget_device_info
get_device_info
, so there is enough time to try all specifiedknown_hosts
.