Simplify socket timeout - Githubissues

home-assistant-libs / pychromecast

Library for Python 3 to communicate with the Google Chromecast.

MIT License

2.54k stars 381 forks source link

Simplify socket timeout #967

Closed emontnemery closed 1 month ago

emontnemery commented 1 month ago

Simplify socket read timeout:

Remove the non-blocking timeout value, it's no longer needed since support for custom event loop is removed
Simplify the timeout, there's no need to pass the value around

This is a fixed version of https://github.com/home-assistant-libs/pychromecast/pull/877, that PR removed the timeout completely which prevented calling the HeartbeatController often enough.