search

home-assistant-libs / zwave-js-server-python

Python library to interact with a Z-Wave JS server.
Apache License 2.0
56 stars 18 forks source link

Fix QRProvisioningInformation.from_dict() #974

Closed raman325 closed 1 month ago

raman325 commented 1 month ago

Currently the logic returns an empty list when supported protocols don't exist, but it should be None. There's a similar problem with additional properties

MartinHjelmare commented 1 month ago

What's wrong with an empty list?

raman325 commented 1 month ago

Nothing is wrong with it, but if we take what we get back from the server and do QRProvisioningInformation.from_dict(data).to_dict() we should get the same output as we had for input right? The empty list makes that not true, it should be None or null