search

home-assistant / Iconic

:art: Auto-generated icon font library for iOS, watchOS and tvOS
Apache License 2.0
1.58k stars 86 forks source link

Updating pod predownload to default for every pod update. #33

Closed shshalom closed 7 years ago

shshalom commented 8 years ago

Hey, I know this library is in beta but I still want to use it. It seems that every time I need to update my pod file I have to point out the location for my font file, which then takes some time until it regenerate the Icon class, more than that if I'm doing plain pod update it installs Iconic with the default Icon class and removes mine..

Is there a better workflow for this?

dzenbot commented 8 years ago

Hey there, thanks for trying it out. Once you've installed Iconic with your own icon font (by assigning a font path like described in the README), you won't need to update it anymore, unless the font file changed. Calling pod install for adding new pods should not override the previous installation with your custom font.

shshalom commented 8 years ago

And that exactly what I've done, but the actual outcome was as I described before. My situation is as follows: I started a new project and I'm looking into different components, adding and removing pods, thus I get to use pod install and update quite a lot. Since Iconic was one of my first libs I added to my project, I found my self installing and updating pods while assigning a font path every time, otherwise it generate and installs the default Icon class.

Any suggestions? Thanks.

dzenbot commented 8 years ago

This was a real concern for my use case too, and I though I had it fixed. I will try to reproduce our use case, and see if there's something we can do about it.

The thing is, to be able to assign a dynamic file path for the library to do all the Swift generation, I used Cocoapod's environment variable but that feature wasn't really meant to do this sorts of things. I wonder if there is a better way.

shshalom commented 8 years ago

For the time being my "solution" for this issue is to embed Iconic inside my project and removing it from the PodFile. I hope that this could be resolve soon so I could use the pod version.

dzenbot commented 8 years ago

Definitely. Will keep this issue alive and see if I can fix it, since it could impact a lot of users. Just curious, what icon font are you using? A custom one?

shshalom commented 8 years ago

Yes, and I just stated another problem which is related to the usage of custom font in issue #34

dzenbot commented 7 years ago

There has been many improvements added in https://github.com/dzenbot/Iconic/pull/55 which should have fixed this issue. Please re-open if the issue persists.

shshalom commented 7 years ago

Great, will do.