Closed stevepeak closed 7 years ago
1 Error | |
---|---|
:no_entry_sign: | swiftlint is not in the user’s PATH, or it failed to install |
Generated by :no_entry_sign: danger
:exclamation: No coverage uploaded for pull request base (
master@96f1b7b
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #68 +/- ##
=========================================
Coverage ? 61.84%
=========================================
Files ? 14
Lines ? 697
Branches ? 1
=========================================
Hits ? 431
Misses ? 266
Partials ? 0
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 96f1b7b...f1c40da. Read the comment docs.
@stevepeak: I ported your changes in https://github.com/dzenbot/Iconic/pull/66 to see them reflected, but the paths to ignore are still showing. Anything else I could do? Also, what's the best practice when it comes to tests, should code coverage include them? Probably not, right?
Our new pattern matching broke this style in effort to respect both Glob and Regexp. We are considering adding it back, but for now this will patch it up.