home-assistant / Iconic

:art: Auto-generated icon font library for iOS, watchOS and tvOS
Apache License 2.0
1.58k stars 86 forks source link

Rebuild using bitcode error #73

Closed N7Alpha closed 4 years ago

N7Alpha commented 6 years ago

I get this error when trying to compile my app to my device.

"/Users/johnrehbein/Library/Developer/Xcode/DerivedData/FlipBook-dvfxorfebyxoypbxslfercvccsye/Build/Products/Debug-iphoneos/Iconic/Iconic.framework/Iconic' does not contain bitcode. You must rebuild it with bitcode enabled (Xcode setting ENABLE_BITCODE), obtain an updated library from the vendor, or disable bitcode for this target. for architecture arm64"

I'm not really sure how to rebuild this framework, so an update would be nice. For now I've just disabled bitcode in my app.

dzenbot commented 6 years ago

I personally don't use bitcode, so it has never been an issue for me. Maybe you can investigate how to make it build with it, and submit a PR? Open source software is not free software: you got to contribute, after all, you're a dev too right?

alexbrashear commented 6 years ago

any update on this? Been investigating and having trouble with the build settings on the pod side

dzenbot commented 6 years ago

@alexbrashear try a bit harder and fix it, and contribute. There is no such thing as free help, specially if you don’t even help yourself.

ebeem commented 6 years ago

@dzenbot hey, to fix this issue, we simply have to enable bit code in the Iconic project itself, this has to update this repo in other words. However, I am not sure if this will have any other sequences.

the updated code is in Iconic.xcconfig

line#2

old ENABLE_BITCODE = NO

new ENABLE_BITCODE = YES

dzenbot commented 6 years ago

@ebeem or @N7Alpha mind submitting a PR and testing it? Like I said, I don't use such feature so I do not have the adequate environment to test it properly, but I'm more than happy to merge it works as expected.

dzenbot commented 4 years ago

Closing as old/unwanted