home-assistant / Iconic

:art: Auto-generated icon font library for iOS, watchOS and tvOS
Apache License 2.0
1.58k stars 87 forks source link

Unexpected behavior when installing custom fonts #76

Closed ghost closed 6 years ago

ghost commented 6 years ago

per the documentation, I've included Iconic in my pod file pod 'Iconic', :git => 'https://github.com/dzenbot/Iconic.git', :tag => '1.3' I perform the follow steps to update my pods.

FONT_PATH='/path/to/font/ionicons.ttf' pod install

FONT_PATH='/path/to/font/ionicons.ttf' pod update Iconic

the expected behavior is to see Ionicons.swift in my Pods/Pods/Iconic directory along with IconDrawable.swift and IconImageView.swift, but instead the generated file is FontAwesomeIcon.swift

Side Node

The following is presented as a result of running the command.

Pre-downloading: `Iconic` from `https://github.com/dzenbot/Iconic.git`, tag `1.3`
Downloading dependencies
...
Installing Iconic 1.2 (was 1.2)
Generating Pods project
Integrating client project
Sending stats
Pod installation complete! There are 6 dependencies from the Podfile and 6 total pods installed.

I would think that having the 1.3 tag would result in installing Iconic 1.3

ghost commented 6 years ago

Instead of entering it as pod 'Iconic', :git => 'https://github.com/dzenbot/Iconic.git', :tag => '1.3'

I entered it as just pod 'Iconic'

and it installed 1.3

ghost commented 6 years ago

thanks @SuttJ that resulted in the installation of Iconic 1.3

dzenbot commented 6 years ago

Closing as not an issue anymore.