Optimizing compiler check on some variables

home-assistant / Iconic

:art: Auto-generated icon font library for iOS, watchOS and tvOS

Apache License 2.0

1.58k stars 86 forks source link

Optimizing compiler check on some variables #89

Closed dzenbot closed 4 years ago

dzenbot commented 4 years ago

The compiler fails to check how exhaustive some switches are with the warning "The compiler is unable to check that this switch is exhaustive in reasonable time".

The easiest solution is to add a default to these switch statements, to trick the compiler.

Fix https://github.com/home-assistant/Iconic/issues/87

homeassistant commented 4 years ago

Hi @dzenbot,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

dzenbot commented 4 years ago

DANGER is failing...

dzenbot commented 4 years ago

Closing this https://github.com/home-assistant/Iconic/pull/88 got merged