hassfest: Unable to parse package version when requirement contains git

home-assistant / actions

GitHub Actions for Home Assistant workflows

Apache License 2.0

27 stars 25 forks source link

hassfest: Unable to parse package version when requirement contains git #92

Open mill1000 opened 1 year ago

mill1000 commented 1 year ago

I'm attempting to run hassfest against a custom component that currently uses a git repository as a requirement. I'm using the format specified by the docs here.

e.g.

"requirements": ["git+https://github.com/mill1000/midea-msmart.git"],

hassfest is failing with the following error:

Error: R] [REQUIREMENTS] Unable to parse package version (+https://github.com/mill1000/midea-msmart.git) for git.

rytilahti commented 6 months ago

andyb2000 commented 1 month ago

This appears to still be an issue, however based o the updated docs

{
  "requirements": ["<project> @ git+https://github.com/<user>/<project>.git@<git ref>"]
}

hassfest errors out with Error: R] [REQUIREMENTS] Requirement ...blah... contains a space

It seems to be failing due to the SPACE@SPACE Is this a fault in hassfest or hass? @ludeeus is this something you're aware of?

mpw96 commented 1 month ago

Components that declare a requirement as stated above do work as expected. It seems that just the hassfest test is not aware of this format.