search

home-assistant / addons

:heavy_plus_sign: Docker add-ons for Home Assistant
https://home-assistant.io/hassio/
Apache License 2.0
1.55k stars 1.5k forks source link

duckdns update (silently) fails for tokens with spaces #2864

Closed 0xDEAD closed 1 year ago

0xDEAD commented 1 year ago

Describe the issue you are experiencing

If you accidentally have a leading or trailing space in the token for duckdns, the update fails without a warning text. I propose we add a match-validator similar to the one for the domains. Does anybody know if duckdns tokens have a specific format other than [a-f0-9-]+, e.g. a fixed number of characters?

What type of installation are you running?

Home Assistant OS

Which operating system are you running on?

Home Assistant Operating System

Which add-on are you reporting an issue with?

Duck DNS

What is the version of the add-on?

1.15.0

Steps to reproduce the issue

  1. setup addon via UI
  2. add leading space to token
  3. restart addon
  4. watch log

System Health information

System Information

version core-2023.1.7
installation_type Home Assistant OS
dev false
hassio true
docker true
user root
virtualenv false
python_version 3.10.7
os_name Linux
os_version 5.15.90
arch aarch64
timezone Europe/Berlin
config_dir /config
Home Assistant Community Store GitHub API | ok -- | -- GitHub Content | ok GitHub Web | ok GitHub API Calls Remaining | 4967 Installed Version | 1.30.1 Stage | running Available Repositories | 1193 Downloaded Repositories | 4
Home Assistant Cloud logged_in | true -- | -- subscription_expiration | 1. März 2023 um 01:00 relayer_connected | true remote_enabled | true remote_connected | true alexa_enabled | false google_enabled | true remote_server | eu-central-1-2.ui.nabu.casa can_reach_cert_server | ok can_reach_cloud_auth | ok can_reach_cloud | ok
Home Assistant Supervisor host_os | Home Assistant OS 9.5 -- | -- update_channel | stable supervisor_version | supervisor-2023.01.1 agent_version | 1.4.1 docker_version | 20.10.22 disk_total | 6.5 GB disk_used | 4.0 GB healthy | true supported | true board | odroid-c2 supervisor_api | ok version_api | ok installed_addons | Spotify Connect (0.12.2), Terminal & SSH (9.6.1), Mosquitto broker (6.1.3), ESPHome (2022.12.8), Duck DNS (1.15.0), Studio Code Server (5.5.2), NGINX Home Assistant SSL proxy (3.2.0)
Dashboards dashboards | 1 -- | -- resources | 0 mode | auto-gen
Recorder oldest_recorder_run | 29. Januar 2023 um 16:24 -- | -- current_recorder_run | 30. Januar 2023 um 15:10 estimated_db_size | 33.65 MiB database_engine | sqlite database_version | 3.38.5
Sonoff version | 3.3.1 (b20e33c) -- | -- cloud_online | 4 / 4 local_online | 3 / 3

Anything in the Supervisor logs that might be useful for us?

No response

Anything in the add-on logs that might be useful for us?

No response

Additional information

No response

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.