home-assistant / addons

:heavy_plus_sign: Docker add-ons for Home Assistant
https://home-assistant.io/hassio/
Apache License 2.0
1.53k stars 1.49k forks source link

File editor: resizing browser reloads file #3147

Closed ReenigneArcher closed 5 months ago

ReenigneArcher commented 1 year ago

Describe the issue you are experiencing

Resizing the browser (snapping it to a corner/edge/etc), causes the loaded file to be reloaded... thus losing any unsaved changes.

What type of installation are you running?

Home Assistant OS

Which operating system are you running on?

Home Assistant Operating System

Which add-on are you reporting an issue with?

File editor

What is the version of the add-on?

5.6.0

Steps to reproduce the issue

  1. Open file
  2. Make changes
  3. Resize/snap browser to edge of screen

System Health information

System Information

version core-2023.7.3
installation_type Home Assistant OS
dev false
hassio true
docker true
user root
virtualenv false
python_version 3.11.4
os_name Linux
os_version 6.1.34
arch x86_64
timezone America/New_York
config_dir /config
Home Assistant Community Store GitHub API | ok -- | -- GitHub Content | ok GitHub Web | ok GitHub API Calls Remaining | 4895 Installed Version | 1.32.1 Stage | running Available Repositories | 1261 Downloaded Repositories | 12
Home Assistant Cloud logged_in | false -- | -- can_reach_cert_server | ok can_reach_cloud_auth | ok can_reach_cloud | ok
Home Assistant Supervisor host_os | Home Assistant OS 10.3 -- | -- update_channel | stable supervisor_version | supervisor-2023.07.1 agent_version | 1.5.1 docker_version | 23.0.6 disk_total | 30.8 GB disk_used | 13.9 GB healthy | true supported | true board | ova supervisor_api | ok version_api | ok installed_addons | Samba share (10.0.2), Duck DNS (1.15.0), File editor (5.6.0), phpMyAdmin (0.8.7), MariaDB (2.6.1), Nginx Proxy Manager (0.12.3), Check Home Assistant configuration (3.11.0), ADB - Android Debug Bridge (0.8.0), AdGuard Home (4.8.12), Network UPS Tools (0.12.0), motionEye (0.19.1), AppDaemon (0.13.3), Z-Wave JS (0.1.84), Advanced SSH & Web Terminal (15.0.5)
Dashboards dashboards | 3 -- | -- resources | 11 views | 23 mode | storage
Recorder oldest_recorder_run | July 17, 2023 at 8:48 PM -- | -- current_recorder_run | July 24, 2023 at 2:08 PM estimated_db_size | 190.50 MiB database_engine | mysql database_version | 10.6.12

Anything in the Supervisor logs that might be useful for us?

No response

Anything in the add-on logs that might be useful for us?

No response

Additional information

No response

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

ReenigneArcher commented 1 year ago

bump

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

ReenigneArcher commented 1 year ago

Working now 🤷‍♂️

0anton commented 8 months ago

Editor discards not saved edits, when browser window is resized. Lost my work because of that.

File editor - Current version: 5.7.0 (Changelog) Started in Chrome Version 120.0.6099.225 (Official Build) (64-bit)

Shall be re-opened, @ReenigneArcher?

ReenigneArcher commented 8 months ago

Yes, it looks to still be an issue... but does now require going to/from a very narrow browser window, instead of just any resize.

github-actions[bot] commented 7 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

ReenigneArcher commented 7 months ago

bump

github-actions[bot] commented 6 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

0anton commented 6 months ago

It's still relevant.

github-actions[bot] commented 5 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.