search

home-assistant / addons

:heavy_plus_sign: Docker add-ons for Home Assistant
https://home-assistant.io/hassio/
Apache License 2.0
1.57k stars 1.51k forks source link

Add support for mariadb server config parameter #3763

Open danielszilagyi opened 2 months ago

danielszilagyi commented 2 months ago

Fixes #3754

Summary by CodeRabbit

coderabbitai[bot] commented 2 months ago
📝 Walkthrough
📝 Walkthrough ## Walkthrough The changes in this pull request update the MariaDB add-on to version 2.7.2, introducing new optional configuration parameters, `parameters.innodb_buffer_pool_size` and `mariadb_server_args`, which allow users to adjust server settings. These enhancements aim to address issues encountered during Home Assistant schema updates, particularly for users with large databases. The documentation and configuration files have been updated accordingly to reflect these changes. ## Changes | Files | Change Summary | |-----------------------------------------|-------------------------------------------------------------------------------------------------------------| | mariadb/CHANGELOG.md, mariadb/DOCS.md | Added new version 2.7.2 with optional configuration for `parameters.innodb_buffer_pool_size` and `mariadb_server_args`. | | mariadb/config.yaml | Updated version to 2.7.2, added `innodb_buffer_pool_size: 128M` in `options`, defined it in `schema`, and added `mariadb_server_args`. | | mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-core/run | Modified startup script to dynamically include command line parameters from configuration. | ## Assessment against linked issues | Objective | Addressed | Explanation | |----------------------------------------------------------------------|-----------|---------------------------------------------------| | Add option to persistently configure innodb_buffer_pool_size via UI (3754) | ✅ | |
📜 Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
📥 Commits Files that changed from the base of the PR and between 5ea053bf2e1819d8987843d4182a69c9684bf760 and 5c1a4ef878e93b4405e181737648ce2eeeec2650.
📒 Files selected for processing (1) * mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-core/run (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1) * mariadb/rootfs/etc/s6-overlay/s6-rc.d/mariadb-core/run
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` or `@coderabbitai title` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
danielszilagyi commented 2 months ago

@coderabbitai review

danielszilagyi commented 2 months ago

Hm, I see you came up with a somewhat generic approach, which is kinda interesting.

Does this work really? I wonder since the options according to mysqld --help --verbose uses dashes and a equal sign (--innodb-buffer-pool-size=#).

It worked in dev container:


[19:24:05] INFO: Starting MariaDB with command line parameters: --innodb_buffer_pool_size=512M

116 root      0:11 mysqld --datadir=/data/databases --user=root --innodb_buffer_pool_size=512M

MariaDB [(none)]> show variables like '%innodb_buffer_pool_size%';
+-------------------------+-----------+
| Variable_name           | Value     |
+-------------------------+-----------+
| innodb_buffer_pool_size | 536870912 |
+-------------------------+-----------+
1 row in set (0.006 sec)
`
samtygier commented 1 week ago

Is someone able to reopen the issue https://github.com/home-assistant/addons/issues/3754 ?