home-assistant / alerts.home-assistant.io

Home Assistant Alerts
https://alerts.home-assistant.io
37 stars 71 forks source link

Add UniFi OS 4.x backward incompatible alert #633

Closed TheJulianJES closed 3 months ago

TheJulianJES commented 3 months ago

Proposed change

This removes the old alert about UniFi Protect 3.x being incompatible, as it's compatible with HA since multiple months now. Instead, the alert is replaced with one mentioning that UniFi OS 4.x is still incompatible with the UniFi Protect integration.

Additional information

Whilst I dislike the advice of not upgrading to UniFi OS 4.x, this is the only workaround that doesn't involve editing the library for now. I really hope we can fix the integration soon. For now, an alert is the best thing to do IMO.

The UniFi OS 4.x issue is tracked here:

UniFi OS 4.x is not to be mixed up with UniFi Protect 4.x. Protect 4.x also has some issues with the HA integration, but they aren't major issues compared to the OS 4.x one, see:

If wanted, I can also add a note about Protect 4.x, but I don't think it's really necessary.

Note

UniFi OS 4.x is still in EA for now. Even though the documentation for the Protect integration states that EA is not supported, a lot of users are upgrading and notice that the integration breaks completely (no workaround). To warn those users, this alert should be added. It's likely that the release goes to RC/GA soon, too.

Due to the unfortunate circumstances regarding the Protect integration, it's still not updated to support any of the 4.x updates to UniFi OS/Protect.

SeraphimSerapis commented 3 months ago

@TheJulianJES May I suggest to also add a brief mention of disabling auto updates to prevent from "accidentally" upgrading to 4.0.X?

GeorgeCastanza commented 3 months ago

Where are we at with this?

The advice above says: OK to update to Protect 4.x But the advice in the Protect thread says: dont update to Protect 4.x

Not a narky question, just a clarification..... Unifi OS 3.x Protect 3.x

TheJulianJES commented 3 months ago

@GeorgeCastanza This is just regarding UniFi OS 4.x which definitely breaks stuff (as soon as the cookie expires). UniFi Protect 4.x should be fine, as long as you don't use a custom GIF on a doorbell exposed to HA.

jasperslits commented 3 months ago

Is that really adding value? The home assistant documentation clearly mentions this: "Using Early Access Release Candidate versions of UniFi Protect or UniFi OS will likely cause your UniFi Protect integration to break unexpectedly. "

How many safeguards does one need in HA if you enable RC / EA with Ubiquiti?

TheJulianJES commented 3 months ago

It's currently still in EA, but as there's no primary maintainer of the library at the moment, it'll likely go to RC and then GA, before the integration gets fixed. There are already too many people updating as-is and the current alert regarding UniFi Protect 3.x is unnecessary. This would be more helpful.

TheJulianJES commented 3 months ago

An issue with this PR is that it'll create a repair for all users of the UniFi Protect integration, even if they've not yet upgraded to UnIFi OS 4.x (although that's kind of the point: to act as a warning). I'll mark it as a draft for now to make sure it's not merged without reading this.

Although this wouldn't follow repair guidelines, we should (IMO) still consider if we want to add this alert if UniFi OS 4.x goes fully GA/Official (assuming the integration isn't updated yet). The alert/repair would act as a warning for users not to upgrade then (or expect the Protect integration to break).

Obviously, the best thing would be to fix the Protect integration instead of this.

frenck commented 3 months ago

Fixed by 2024.6.2: https://github.com/home-assistant/core/releases/tag/2024.6.2