search

home-assistant / architecture

Repo to discuss Home Assistant architecture
315 stars 99 forks source link

Add ADR 0007: Config yaml structure for integrations #361

Closed MartinHjelmare closed 4 years ago

MartinHjelmare commented 4 years ago

Closes #142

This is broken out from #289. See that PR for the discussion.

frenck commented 4 years ago

Just thought about this a little more. While we are not accepting any new ones after this has been merged. Any thoughts about the existing single platform integrations? E.g., do we accept changes on those? Or do we require them to be migrated when new features are introduced? (excluding bug fixes from that).

And lastly, what about currently open PRs that are violating this?

MartinHjelmare commented 4 years ago
  1. Do we require existing single platform integrations to be migrated when new features are introduced?
  2. What about currently open PRs that are violating this?
  1. I think we should not accept changes for the config, but other changes could be ok.
  2. If we haven't started review of the PR, we'll require them to update. If we have started review I think it's ok to merge as is.