search

home-assistant / architecture

Repo to discuss Home Assistant architecture
315 stars 99 forks source link

Allow nesting light groups #437

Closed ryanjohnsontv closed 3 years ago

ryanjohnsontv commented 3 years ago

Context

Currently when grouping light entities into a group, I am unable to reference that group as an entity for another light group.

Proposal

Allow nesting light group entities into other light groups. For instance light group "Living Room Fan Lights" has entities light.living_room_fan_light_1 & light.living_room_fan_light_2, but for convenience I also have a light group, "Living Room Down Lights", for my additional recessed lights in my living room. Currently, I am unable to create a parent light group, "Living Room Lights", that includes just the two light entities generated from those two light groups.

Consequences

This will make organizing a large collections of lights much easier, as individual light entities will not need to be repeated in YAML.

frenck commented 3 years ago

So this makes light groups that have dependencies on other light groups when creating them.

What is your implementation suggestion for this @ryanjohnsontv?

balloob commented 3 years ago

Why is this not possible today? You can just put a light.living_room_fan in your other group ?

ryanjohnsontv commented 3 years ago

Why is this not possible today? You can just put a light.living_room_fan in your other group ?

In its current state when I add an existing light group in another light group, the new group appears as unavailable. image image

KevinCathcart commented 3 years ago

This sounds more like an implementation issue/bug/limitation than an architectural issue.

Except in the obviously bad scenario of group A including Group B, which includes Group A, I don't immediately see anything in the code that should cause this not to work.

I do however see a recent bugfix that seems like it could be related.

balloob commented 3 years ago

Yeah, this is a bug. Closing this. Re-test if it still occurs in 0.116 beta (releasing today) and fiel a bug if it does.