home-assistant / architecture

Repo to discuss Home Assistant architecture
313 stars 100 forks source link

Alarm Control Panel: The code parameter to arm and disarm should differentiate whether a keypad is shown or not #461

Closed davesmeghead closed 1 year ago

davesmeghead commented 3 years ago

Context

In the Alarm Control Panel Entity frontend, either a keypad (with text entry) is shown or not depending on a code_format property.

Current operation:

Proposal

Proposed operation:

This latter case can be used by the backend, it knows that a keypad was shown to the user but no code was entered.

Consequences

It prevents the backend having to know whether a code was asked for. Many of the current "alarm_control_panel" Entity integrations ignore the code parameter but some use it. This is mainly a change in the frontend but the backend integrations would need to be checked.

frenck commented 1 year ago

This architecture issue is old, stale, and possibly obsolete. Things changed a lot over the years. Additionally, we have been moving to discussions for these architectural discussions.

For that reason, I'm going to close this issue.

../Frenck

davesmeghead commented 1 year ago

I'm afraid I don't agree with you, the keypad is still used for various alarms and the integrations need to know whether the user enters a code when asked.
However, you're in control of Home Assistant and so it's clearly your decision.