search

home-assistant / architecture

Repo to discuss Home Assistant architecture
313 stars 100 forks source link

Introduce a new device_class for casement windows #524

Closed chemelli74 closed 3 years ago

chemelli74 commented 3 years ago

Context

In Europe we use casement windows more than up/down windows, more common on US.

Proposal is to create a new device_class for the that variant. Name is mutuate from material design:

mdi-window-closed-variant mdi-window-open-variant

I was also made aware of a discussion about this: what-the-heck-is-up-with-the-window-icon

Proposal

PR for new device_class: #46923

Consequences

The idea is to allow easy customization for users having a on/off icons that otherwise needs a template for each entity.

bdraco commented 3 years ago

HomeKit, alexa, and maybe google assistant would need to be updated to know about the new device class.

I don't think we should let MDI drive naming here. DEVICE_CLASS_WINDOW_CASEMENT seems like a better choice.

chemelli74 commented 3 years ago

HomeKit, alexa, and maybe google assistant would need to be updated to know about the new device class.

Maybe it's time to move definitions to a dedicated device_class.py and import on all integrations.

I don't think we should let MDI drive naming here. DEVICE_CLASS_WINDOW_CASEMENT seems like a better choice.

Good suggestion, once this is approved, I'll update the PR accordingly. Thx.

Simone

chemelli74 commented 3 years ago

Just noticed that discussions should be preferred to issue. Should I close this one and move there ?

Simone