search

home-assistant / architecture

Repo to discuss Home Assistant architecture
311 stars 101 forks source link

Update 0014-home-assistant-supervised.md #572

Closed mrdavidaylward closed 3 years ago

mrdavidaylward commented 3 years ago

This also requires an up to date version of jq to work.

homeassistant commented 3 years ago

Hi @mrdavidaylward,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

mrdavidaylward commented 3 years ago

Signed and sorted

mrdavidaylward commented 3 years ago

changed to installer section

mrdavidaylward commented 3 years ago

This is just the version I have tested, but ive updated the change to the installer section and excluded version, as said above the version shouldn't matter. I had a look at the code and jq is fulfilling a basic job so i agree the version shouldn't matter.

On Thu, 03 Jun 2021, 12:26 Franck Nijhof, @.***> wrote:

@.**** commented on this pull request.

In adr/0014-home-assistant-supervised.md https://github.com/home-assistant/architecture/pull/572#discussion_r644676168 :

@@ -27,6 +27,7 @@ Docker CE (Community Edition) is the only supported containerization method for

  • NetworkManager >= 1.14.6
  • AppArmor == 2.13.x (built into the kernel)
  • Debian Linux Debian 10 aka Buster (no derivatives) +- jq = 1.5

Unresolved this comment as the question wasn't answered.

Additionally: Why did you change it without a version in this case?

I still believe this is a better fit @ the installer documentation.

@mrdavidaylward https://github.com/mrdavidaylward ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/home-assistant/architecture/pull/572#discussion_r644676168, or unsubscribe https://github.com/notifications/unsubscribe-auth/AONSDNKOQQIJVRXSKGVWSVTTQ5KEHANCNFSM4567LY2Q .

frenck commented 3 years ago

installer section and excluded version

I didn't suggest the installer section (that isn't an installer section btw). I suggest the installer documentation: https://github.com/home-assistant/supervised-installer

mrdavidaylward commented 3 years ago

God sorry blond moment

mrdavidaylward commented 3 years ago

I don't see an appropriate place in that page to insert a requirement though

frenck commented 3 years ago

Lets add it to the installation steps listed here:

https://github.com/home-assistant/supervised-installer#installation

I'm closing the PR on this end, as this should not go into the ADR.