home-assistant / companion.home-assistant

:book: Home Assistant Companion docs
https://companion.home-assistant.io/
Other
78 stars 266 forks source link

Fix action name in actionable notification migration #1012

Closed myTselection closed 5 months ago

myTselection commented 6 months ago

align actionName and name of action to make it clear these should match to trigger on the desired event

jpelgrom commented 5 months ago

Thanks for the suggestion, but it looks like the event name changed in step 1 from SOUND_ALARM (line 319) to ALARM (line 330). That means your suggestion updating it everywhere in step 2, specifically line 348, would still result in it not working as expected.

To fix this:

(I wonder for how many people this migration info is still relevant 2.5+ years later)