home-assistant / companion.home-assistant

:book: Home Assistant Companion docs
https://companion.home-assistant.io/
Other
78 stars 267 forks source link

Add documentation for even more intent extra types #931

Closed pascal-t closed 1 year ago

pascal-t commented 1 year ago

Added more types to the intent extras. This is the documentation for the changes in home-assistant/android#3436

jpelgrom commented 1 year ago

Could you keep the line endings for the file the same, to prevent Git from marking every line as changed and make it easier to review?

pascal-t commented 1 year ago

Of course. Windows didn't show me the changes. How should I fix it? New commit, amend and force push or new PR all together?

jpelgrom commented 1 year ago

A force push like you've done is fine 👍

For the new options, please add a beta label after the type so users know what to expect based on the version of the app they're using. <span class='beta'>BETA</span>

pascal-t commented 1 year ago

Done. I also added the beta tag to the example, since it uses one of the types I added.

pascal-t commented 1 year ago

Hi, I just noticed that when I add a BETA Tag in the beginning of a paragraph, it breaks the Markdown rendering for the whole paragraph: grafik

Is there a way around that, or should I not worry about it?

TomBrien commented 1 year ago

Probably just stick it on its own line/paragraph below the sub header. This way it doesn't read as part of the sentence. I'll look into that issue though all the same.

pascal-t commented 1 year ago

Alright I put them in separate lines before the paragraph. I rearranged the section about the extras and changed the part about urlencoded Strings to use :String.urlencoded, but kept :urlencoded as an example in the list of all types.