home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
72.67k stars 30.42k forks source link

"Signal Messenger" generates errors after updating signal-cli to v0.68 #101061

Closed Herbs851 closed 1 year ago

Herbs851 commented 1 year ago

The problem

After updating my signal-cli container to v0.68 I get error messages.

https://github.com/bbernhard/signal-cli-rest-api/releases/tag/0.68

Despite this, the messages are still being sent.

What version of Home Assistant Core has the issue?

2023.9.3

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Container

Integration causing the issue

Signal Messenger

Link to integration documentation on our website

https://www.home-assistant.io/integrations/signal_messenger/

Diagnostics information

No response

Example YAML snippet

Service notify declare like :

- name: Signal Herbs
  platform: signal_messenger
  url: "http://192.168.0.22:8080"
  number: "sender_number"
  recipients: "recipient_number"

Notification with this kind of code :

service: notify.signal_xxxx
data:
  message: test

Anything in the logs that might be useful for us?

File "/usr/src/homeassistant/homeassistant/components/notify/legacy.py", line 264, in _async_notify_message_service
    await self.async_send_message(**kwargs)
  File "/usr/src/homeassistant/homeassistant/components/notify/legacy.py", line 240, in async_send_message
    await self.hass.async_add_executor_job(
  File "/usr/local/lib/python3.11/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/signal_messenger/notify.py", line 109, in send_message
    raise ex
  File "/usr/src/homeassistant/homeassistant/components/signal_messenger/notify.py", line 104, in send_message
    self._signal_cli_rest_api.send_message(
  File "/usr/local/lib/python3.11/site-packages/pysignalclirestapi/api.py", line 221, in send_message
    raise exc
  File "/usr/local/lib/python3.11/site-packages/pysignalclirestapi/api.py", line 216, in send_message
    raise SignalCliRestApiError(json_resp["error"])
pysignalclirestapi.api.SignalCliRestApiError: strconv.ParseInt: parsing "WARN  ManagerImpl - No profile name set. When sending a message it's recommended to set a profile name with the updateProfile command. This may become mandatory in the future.\n1695911116154": invalid syntax

Additional information

rollback to docker.io/bbernhard/signal-cli-rest-api:0.67 fix the issue.

home-assistant[bot] commented 1 year ago

Hey there @bbernhard, mind taking a look at this issue as it has been labeled with an integration (signal_messenger) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `signal_messenger` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign signal_messenger` Removes the current integration label and assignees on the issue, add the integration domain after the command.

(message by CodeOwnersMention)


signal_messenger documentation signal_messenger source (message by IssueLinks)

bbernhard commented 1 year ago

What for sure is/will become a problem is, that you haven't set your profile name. Please do so with the Update Profile REST call (see https://bbernhard.github.io/signal-cli-rest-api/#/Profiles/put_v1_profiles__number_)

Apart from that, I would need more infos on why it is failing. Do you see any errors in the docker container log file?

Herbs851 commented 1 year ago

Thanks for your reply.

After setting up the profile, everything is working properly again.