home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
72.33k stars 30.27k forks source link

Econet thermostat unit locked to Fahrenheit #102422

Closed DailytheNoob closed 8 months ago

DailytheNoob commented 11 months ago

The problem

The unit of measure in the Thermostat entity is converted to Fahrenheit even though both the Thermostat itself and HA are set to Celsius.

Here is where it is forced to Fahrenheit: https://github.com/home-assistant/core/blob/dev/homeassistant/components/econet/climate.py#L67 _attr_temperature_unit = UnitOfTemperature.FAHRENHEIT

What this causes: The UI shows odd fractions of Celsius that conveniently map to Fahrenheit

I'm not proficient enough to know how to fix that. I tried just taking off the .FAHRENHEIT and also replacing it with .CELSIUS with no change.

If that's just something that Rheem decided was a good idea because they aren't the brightest and not many people use Celsius, ¯\_(ツ)_/¯

What version of Home Assistant Core has the issue?

core-2023.10.3

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Container

Integration causing the issue

Econet

Link to integration documentation on our website

https://www.home-assistant.io/integrations/econet/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 11 months ago

Hey there @vangorra, @w1ll1am23, mind taking a look at this issue as it has been labeled with an integration (econet) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `econet` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign econet` Removes the current integration label and assignees on the issue, add the integration domain after the command.

(message by CodeOwnersMention)


econet documentation econet source (message by IssueLinks)

w1ll1am23 commented 11 months ago

I believe this is a quirk of their API. All temperatures return in Fahrenheit. Its been a long time since I've looked at this, but I remember thinking it didn't make much sense. Someone with a thermostat or @DailytheNoob if you enable debug logs could confirm if that's the case. Pyeconet will log out the API responses.

issue-triage-workflows[bot] commented 8 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.