search

home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
72.72k stars 30.45k forks source link

2023.11 broke Moen Flo integration #103322

Closed edjurkowski closed 11 months ago

edjurkowski commented 11 months ago

The problem

I confirmed 2023.11 broke Moen Flo by restoring a previous MV snapshot.

System Information

version core-2023.11.0
installation_type Home Assistant OS
dev false
hassio true
docker true
user root
virtualenv false
python_version 3.11.6
os_name Linux
os_version 6.1.59
arch x86_64
timezone America/New_York
config_dir /config
Home Assistant Community Store GitHub API | ok -- | -- GitHub Content | ok GitHub Web | ok GitHub API Calls Remaining | 4883 Installed Version | 1.33.0 Stage | running Available Repositories | 1324 Downloaded Repositories | 8
Home Assistant Cloud logged_in | true -- | -- subscription_expiration | January 8, 2024 at 7:00 PM relayer_connected | true relayer_region | us-east-1 remote_enabled | true remote_connected | true alexa_enabled | false google_enabled | true remote_server | us-east-1-5.ui.nabu.casa certificate_status | ready can_reach_cert_server | ok can_reach_cloud_auth | ok can_reach_cloud | ok
Home Assistant Supervisor host_os | Home Assistant OS 11.1 -- | -- update_channel | stable supervisor_version | supervisor-2023.10.1 agent_version | 1.6.0 docker_version | 24.0.6 disk_total | 30.8 GB disk_used | 20.1 GB healthy | true supported | true board | ova supervisor_api | ok version_api | ok installed_addons | Samba share (10.0.2), Advanced SSH & Web Terminal (15.1.0), File editor (5.6.0), Matter Server (4.10.1), Zigbee2MQTT (1.33.2-1), Mosquitto broker (6.3.1), Home Assistant Google Drive Backup (0.111.1), Studio Code Server (5.13.0), VLC (0.2.0), ESPHome (2023.10.6), Silicon Labs Flasher (0.2.0), Silicon Labs Multiprotocol (2.3.2)
Dashboards dashboards | 3 -- | -- resources | 1 views | 15 mode | storage
Recorder oldest_recorder_run | October 24, 2023 at 8:02 PM -- | -- current_recorder_run | November 3, 2023 at 11:15 AM estimated_db_size | 152.02 MiB database_engine | sqlite database_version | 3.41.2

What version of Home Assistant Core has the issue?

System Information version | core-2023.11.0 -- | -- installation_type | Home Assistant OS dev | false hassio | true docker | true user | root virtualenv | false python_version | 3.11.6 os_name | Linux os_version | 6.1.59 arch | x86_64 timezone | America/New_York config_dir | /config
Home Assistant Community Store GitHub API | ok -- | -- GitHub Content | ok GitHub Web | ok GitHub API Calls Remaining | 4883 Installed Version | 1.33.0 Stage | running Available Repositories | 1324 Downloaded Repositories | 8
Home Assistant Cloud logged_in | true -- | -- subscription_expiration | January 8, 2024 at 7:00 PM relayer_connected | true relayer_region | us-east-1 remote_enabled | true remote_connected | true alexa_enabled | false google_enabled | true remote_server | us-east-1-5.ui.nabu.casa certificate_status | ready can_reach_cert_server | ok can_reach_cloud_auth | ok can_reach_cloud | ok
Home Assistant Supervisor host_os | Home Assistant OS 11.1 -- | -- update_channel | stable supervisor_version | supervisor-2023.10.1 agent_version | 1.6.0 docker_version | 24.0.6 disk_total | 30.8 GB disk_used | 20.1 GB healthy | true supported | true board | ova supervisor_api | ok version_api | ok installed_addons | Samba share (10.0.2), Advanced SSH & Web Terminal (15.1.0), File editor (5.6.0), Matter Server (4.10.1), Zigbee2MQTT (1.33.2-1), Mosquitto broker (6.3.1), Home Assistant Google Drive Backup (0.111.1), Studio Code Server (5.13.0), VLC (0.2.0), ESPHome (2023.10.6), Silicon Labs Flasher (0.2.0), Silicon Labs Multiprotocol (2.3.2)
Dashboards dashboards | 3 -- | -- resources | 1 views | 15 mode | storage
Recorder oldest_recorder_run | October 24, 2023 at 8:02 PM -- | -- current_recorder_run | November 3, 2023 at 11:15 AM estimated_db_size | 152.02 MiB database_engine | sqlite database_version | 3.41.2

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

No response

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

mib1185 commented 11 months ago

please provide a linkt to the documentation if this integration

edjurkowski commented 11 months ago

Sorry, I don't understand your question.

On Fri, Nov 3, 2023, 1:56 PM Michael @.***> wrote:

please provide a linkt to the documentation if this integration

— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/issues/103322#issuecomment-1792891283, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4BKPFOBZ5LCNRDZKXVSPQLYCUV6RAVCNFSM6AAAAAA64UTBOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJSHA4TCMRYGM . You are receiving this because you authored the thread.Message ID: @.***>

mib1185 commented 11 months ago

You did not filled the "Integration causing the issue" nor the "Link to integration documentation on our website" on the issue template while posting this issue report, so we need at least to know, which exact integration you are having an issue with.

edjurkowski commented 11 months ago

The Moen Flo integration. It is listed as Flo in the add integration menu. I hope this helps.

On Fri, Nov 3, 2023, 4:16 PM Michael @.***> wrote:

You did not filled the "Integration causing the issue" nor the "Link to integration documentation on our website" on the issue template while posting this issue report, so we need at least to know, which exact integration you are having an issue with.

— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/issues/103322#issuecomment-1793041677, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4BKPFJ5FKMKDUPRJSFIGMDYCVGJLAVCNFSM6AAAAAA64UTBOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJTGA2DCNRXG4 . You are receiving this because you authored the thread.Message ID: @.***>

home-assistant[bot] commented 11 months ago

Hey there @dmulcahey, mind taking a look at this issue as it has been labeled with an integration (flo) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `flo` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign flo` Removes the current integration label and assignees on the issue, add the integration domain after the command.

(message by CodeOwnersMention)

flo documentation flo source (message by IssueLinks)

Ylianst commented 11 months ago

I can confirm, the Flo integration is no longer working. It had been intermittent for a while (past few weeks) and now it's stopped. I enabled debugging and will see if I can provide more information. This is fairly critical for me since I have 8+ leak detectors that will not be able to shutoff water.

image

Ylianst commented 11 months ago

Ok, here is the error I am getting:

Logger: homeassistant.components.switch Source: helpers/entity_platform.py:367 Integration: Switch (documentation, issues) First occurred: 12:31:54 PM (2 occurrences) Last logged: 8:23:05 PM Error while setting up flo platform for switch

Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 367, in _async_setup_platform
    await asyncio.gather(*pending)
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 507, in async_add_entities
    await asyncio.gather(*tasks)
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 614, in _async_add_entity
    if self.config_entry and (device_info := entity.device_info):
                                             ^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/flo/entity.py", line 35, in device_info
    serial_number=self._device.serial_number,
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/flo/device.py", line 144, in serial_number
    return self._device_information["serialNumber"]
           ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
KeyError: 'serialNumber'
Ylianst commented 11 months ago

Look like this recent commit broke it https://github.com/home-assistant/core/commit/1a8558012f05fff7fbd01a5605a712f5211aa659. Occurred 2 weeks ago.

mib1185 commented 11 months ago

fix will be included in 2023.11.2

Ylianst commented 11 months ago

Thank you!

edjurkowski commented 11 months ago

2023.11.2 can not come too soon for me.

On Sun, Nov 5, 2023 at 6:41 AM Michael @.***> wrote:

fix will be included in 2023.11.2

— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/issues/103322#issuecomment-1793712829, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4BKPFIOIGQ2MNVG7FOJLKLYC53QFAVCNFSM6AAAAAA64UTBOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJTG4YTEOBSHE . You are receiving this because you authored the thread.Message ID: @.***>

-- Regards, Ed Jurkowski @. @.> 610-787-9463

prashker commented 11 months ago

Thank you for the upcoming fix!

edjurkowski commented 11 months ago

Well, good news. 2023.11.2 fixed Moen Flo.

On Fri, Nov 10, 2023 at 12:15 AM Samuel Prashker @.***> wrote:

Thank you for the upcoming fix!

— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/issues/103322#issuecomment-1805101005, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4BKPFP2FGVTSS7FM2I3UMDYDWZ7PAVCNFSM6AAAAAA64UTBOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBVGEYDCMBQGU . You are receiving this because you authored the thread.Message ID: @.***>

-- Regards, Ed Jurkowski @. @.> 610-787-9463