home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.17k stars 30.57k forks source link

Times of the day helper entity does not track daylight saving time change #103639

Open j9brown opened 11 months ago

j9brown commented 11 months ago

The problem

I have a Times of the Day helper configured to turn on at 7:30 am and off at 10:30 pm. It was working reliably until 2023/11/5 when it started turning on at 6:30 am and off at 9:30 pm instead, which coincides with a DST time change.

I noticed this bug a little after 9:30 pm due to the behavior of a device that's driven by this helper. I guessed that the entity just needed a kick to reset its interval timer so I restarted Home Assistant. Sure enough the entity transitioned to the On state as expected. Seems like the entity needs some code to handle time changes.

Here's a snippet of the log book.

November 6, 2023
Dash Schedule turned off
9:30:00 PM - Yesterday
Dash Schedule turned on
6:30:00 AM - Yesterday

November 5, 2023
Dash Schedule turned off
9:30:00 PM - 2 days ago
Dash Schedule turned on
6:30:00 AM - 2 days ago

November 4, 2023
Dash Schedule turned off
10:30:00 PM - 3 days ago
Dash Schedule turned on
7:30:00 AM - 3 days ago

November 3, 2023
Dash Schedule turned off
10:30:00 PM - 4 days ago
Dash Schedule turned on
7:30:00 AM - 4 days ago

What version of Home Assistant Core has the issue?

core-2023.10.3

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

tod

Link to integration documentation on our website

https://www.home-assistant.io/integrations/tod/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 11 months ago

tod documentation tod source

lsowen commented 11 months ago

I am experiencing the exact same issue. Also on 2023.10.3.

Screenshot_20231109-080357

issue-triage-workflows[bot] commented 8 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment šŸ‘ This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

j9brown commented 8 months ago

Bump. This is a DST issue that will affect folks twice a year. Worth fixing.

issue-triage-workflows[bot] commented 5 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment šŸ‘ This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

j9brown commented 5 months ago

This is probably still an issue. Will someone triage it?

issue-triage-workflows[bot] commented 2 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment šŸ‘ This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

j9brown commented 2 months ago

Bump. Is anyone going to look at this issue? It would be nice to fix before the next time change occurs.

d4g commented 20 hours ago

This is hilarious. This issue is open from one daylight saving time to another, not being worked on, as if someone got stuck in the same way as the sensors do.

j9brown commented 20 hours ago

Yeah, Iā€™m disappointed my automations are going to break again soon. Does anyone own this issue?