home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.71k stars 30.83k forks source link

Hydrawise integration - minute-by-minute log entries #103822

Closed threadstone83 closed 10 months ago

threadstone83 commented 1 year ago

The problem

Hello,

I installed and set up the Hydrawise integration. All works as far as I can see. But I get minute-by-minute log entries:

Zone 4 - Garten Ost (Beet Seite, Gewächshaus, hinter Garage) Nächster Zyklus wechselte zu 11. November 2025 um 00:09 00:09:44 - Vor 1 Minute Zone 3 - Garten Mitte (Beet unten + Treppe) Nächster Zyklus wechselte zu 11. November 2025 um 00:09 00:09:44 - Vor 1 Minute Zone 2 - Garten West (Gartenhaus bis Terrasse) Nächster Zyklus wechselte zu 11. November 2025 um 00:09 00:09:44 - Vor 1 Minute Zone 1 - Vorgarten + Schotterweg Nächster Zyklus wechselte zu 11. November 2025 um 00:09 00:09:44 - Vor 1 Minute

I get this entries every minute.

Can you help me how to stop this?

What version of Home Assistant Core has the issue?

2023.11.2

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

hydrawise

Link to integration documentation on our website

https://www.home-assistant.io/integrations/hydrawise/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 1 year ago

Hey there @dknowles2, @ptcryan, mind taking a look at this issue as it has been labeled with an integration (hydrawise) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `hydrawise` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign hydrawise` Removes the current integration label and assignees on the issue, add the integration domain after the command.

(message by CodeOwnersMention)


hydrawise documentation hydrawise source (message by IssueLinks)

dknowles2 commented 1 year ago

I have https://github.com/home-assistant/core/pull/103121 pending to fix this.

The problem is that when a zone is suspended, it's "next cycle time" is interpreted as "now + 2 years". Since "now" is constantly changing (time is weird like that) the value of "next cycle time" also changes constantly too.

I'll ping the PR and see if I can get someone to take a look.

threadstone83 commented 1 year ago

OK. that's weird because it is suspended but I added a date till when it is suspended. The date is the 31st of May and not in two years. Why not this date will be shown? Thank you for your fix. If you need information or if I should test something, just write me. Do you know when the fix will be ready?

N3rdix commented 1 year ago

I would also favor having the set time from the paused zone rather than going "unknown" as it is known. I couldn't find any hint if the API provides that information, in case it doesn't then let's live with "unknown" 😃

threadstone83 commented 1 year ago

That's right. Better "unknown" than a minute-by-minute log 😉

dknowles2 commented 1 year ago

The older API that we're currently using doesn't expose the suspension time expiration. It instead just always returns a nonsensical 1576800000. Once we get migrated to the newer API, we can improve this because it has the resumption time.

threadstone83 commented 1 year ago

That sounds really good. Do you know if the migration is already being worked on?

dknowles2 commented 1 year ago

Yes, I'm working on it, but the review process can be slow.

threadstone83 commented 1 year ago

OK. If I can help, just let me know. I can not write programs but I can test your integration.

dknowles2 commented 10 months ago

I think this is now fixed.

dknowles2 commented 10 months ago

@home-assistant close