home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.56k stars 30.74k forks source link

Litter Robot vacuum.turn_on/vacuum.turn_off deprecation. #104567

Closed dsluo closed 11 months ago

dsluo commented 11 months ago

The problem

I got a notification that vacuum.turn_on/vacuum.turn_off will be deprecated in HA 2024.2. While this probably makes sense for actual robot vacuums, the behavior is not exactly the same for the Litter Robot as turning it off and on again forces it to cycle regardless of the state of the bin.

Maybe an additional service should be added for this functionality?

What version of Home Assistant Core has the issue?

core-2023.11.3

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

litterrobot

Link to integration documentation on our website

https://www.home-assistant.io/integrations/litterrobot/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 11 months ago

Hey there @natekspencer, @tkdrob, mind taking a look at this issue as it has been labeled with an integration (litterrobot) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `litterrobot` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign litterrobot` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


litterrobot documentation litterrobot source (message by IssueLinks)

tkdrob commented 11 months ago

Read the entire deprecation notification. Does that answer your question? The service name just changed

dsluo commented 11 months ago

Litter-Robot vaccum support for the vacuum.turn_on service is deprecated and will be removed in Home Assistant 2024.2; Please adjust any automation or script that uses the service to instead call vacuum.start and select submit below to mark this issue as resolved.

I interpreted this to mean that turn_on had different behavior from start, where turn_on corresponded to the on button and start corresponded to the manual cycle button in the app. After looking at the source, this is indeed not the case.

Maybe the wording for this deprecation warning could be more explicit that the service was renamed, but that's a separate issue.