home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
71.03k stars 29.7k forks source link

Smartthings integration: Samsung fridge sensors are still broken for some refridgerators #104850

Open Queuecumber opened 9 months ago

Queuecumber commented 9 months ago

The problem

Certain samsung refrigerators do not report their entire state nor do they update correctly.

This is the same bug as issue #26230

It still needs to be fixed and the issue was closed a stale by the bot, then it was locked by @andrewsayre because people were commenting on the closed issue.

Discussion should be moved here or #26230 should be reopened, it should never have been closed in the first place.

At the time, productive discussions on the issue were focused around a PR by @andrewsayre #26499 which was closed "temporarily" and never reopened and would have provided a workaround, however it would still be a good idea to talk to someone at smartthings to see if there have been any meaningful fixes on the samsung side for this in the last two years.

The idea would be to deprecate the workaround of using the REST integration which is a hack at best.

The smartthings app can view all of the necessary state and make changes to the temperature set points etc. so there must be an API for it.

What version of Home Assistant Core has the issue?

core-2023.11.3

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Container

Integration causing the issue

SmartThings

Link to integration documentation on our website

https://www.home-assistant.io/integrations/smartthings/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 9 months ago

Hey there @andrewsayre, mind taking a look at this issue as it has been labeled with an integration (smartthings) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `smartthings` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign smartthings` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


smartthings documentation smartthings source (message by IssueLinks)

jkosharek commented 8 months ago

I have the same issue with this integration.

smokedropp commented 8 months ago

Hab das selbe Problem , lediglich der törkontact wird mir richtig angezeigt, alles andere hängt fest , sidebyside.

issue-triage-workflows[bot] commented 5 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

jkosharek commented 5 months ago

Issue still continues, how do we get this looked at?

moebis commented 5 months ago

This still hasn't been fixed. Thank you @Queuecumber for detailing the history as I've followed all of those threads. I even installed the HACS version to try to get this to work. The closest I came was updating the configuration.yaml with the entity names that Samsung showed on my account for temp fridge/freezer, but it ended up breaking something else. I guess an orphaned entity because I tried to hack in my own solution. With some many folks having Samsung Fridges, can we please get someone to look at the fix that was in peer review for 6 months?

Not-Mystify commented 5 months ago

I’m having an issue with my fridge door sensor. It’ll work fine for a while then it just stops updating and stays on closed.

siobhanellis commented 4 months ago

I have temperature sensors not working

Screenshot 2024-04-14 at 15 51 39

jkosharek commented 4 months ago

I have 2 almost identical Cafe Fridges and they have the same sensors and control in the SmartHQ App but one is missing almost everything in HA: Screenshot 2024-04-14 at 12 13 58 PM Screenshot 2024-04-14 at 12 13 47 PM

Mathea90 commented 4 months ago

I also have the problem that only the door state of my Samsung fridge is being updated in Home Assistant. The rest of the values are reporting "unknown". It seems like a few reported issues are related to a similar kind of problem. Unfortunately, I lack the programming skills to fix it. Is somebody able to provide a fix to it?

SGXander commented 4 months ago

I also have the problem that only the door state of my Samsung fridge is being updated in Home Assistant. The rest of the values are reporting "unknown". It seems like a few reported issues are related to a similar kind of problem. Unfortunately, I lack the programming skills to fix it. Is somebody able to provide a fix to it?

Agreed. I think that needs a separate issue as for me it's intermittent ( reports opening but not closing or vice versa but sometimes it's fine)

kooijtjemk2 commented 3 months ago

Apparently this is a problem for a long time now. I'm having the same issues as @siobhanellis postes above. No temps. Nothing i can do then keep an eye on this issue and continue dreaming of a vendor independent standardized api framework for smart devices.

Eoras commented 3 months ago

Can someone repare this ? I don't find where is the code for this :(

ee02217 commented 3 months ago

I have the same problem. Door and power are working, but not temperature.

Yorkie71 commented 2 months ago

Arrived here after purchasing a new Samsung fridge freezer, bought partly because I saw there was HA integration via SmartThings, although it was a nice-to-have and not critical. Like others, I have some data coming though via the official core-based integration but the important ones like the temperatures are in "unknown" state. image The official SmartThings app has that data and the ability to adjust it so I guess it must be possible via the API. It's also odd that there a fridge temperature value but not a freezer. Again, these all exist when looking at the attributes in the SmartThings web app.

I noticed there are a couple of custom integrations that claim to rectify this and I see screenshots that seem to support this but from the discussions, it seem to require a degree of faffery that goes beyond my HA skills and having tinkered with them to some degree, I'd like my HA to stay in a working state!

I hope this can be fixed but given the date on some of these comments, I suspect that the dev is otherwise engaged in which case, I'll live with just getting the power consumption into HA for now.

mfin commented 2 months ago

Exactly the same issues as @Yorkie71 and @siobhanellis. By using this 3rd party integration through HACS, I was able to pull in all the sensors and switches, but I lost the power and energy data.

Would love to see some progress on this issue. Screenshot 2024-06-13 at 10 20 38

bakernigel commented 3 days ago

It seems like the Smartthings core integration is no longer being updated.

I have created a modified version of the core integration that should provide the missing sensors and controls for Samsung appliances.

See https://github.com/bakernigel/smartthings

I only have three devices on my Smartthings account - Family Hub, Wall Oven and Dishwasher and my integration works well with these. Note that I am not able to test whether the integration will break other devices, particularly non Samsung devices, so use it at your own risk.

If you are willing to act as a guinea pig, please give it a try and let me know if it works for you.

If you have an issue, please open a New Issue at https://github.com/bakernigel/smartthings/issues

SGXander commented 3 days ago

It seems like the Smartthings core integration is no longer being updated.

I have created a modified version of the core integration that should provide the missing sensors and controls for Samsung appliances.

See https://github.com/bakernigel/smartthings

I only have three devices on my Smartthings account - Family Hub, Wall Oven and Dishwasher and my integration works well with these. Note that I am not able to test whether the integration will break other devices, particularly non Samsung devices, so use it at your own risk.

If you are willing to act as a guinea pig, please give it a try and let me know if it works for you.

Happy to give it a try, will take a look this weekend. My smartthings only has the fridge and a washing machine and tumble dryer so that should be ok?

bakernigel commented 3 days ago

@SGXander I have an LG washer/dryer so I don't know if it will work with Samsung. It should. If you have time can you go to https://my.smartthings.com/advanced and go to Devices for your washer and dryer and use the "Export Data" button for the Attributes and save as a CSV and attach to this post. Thanks

SGXander commented 1 day ago

@SGXander I have an LG washer/dryer so I don't know if it will work with Samsung. It should. If you have time can you go to https://my.smartthings.com/advanced and go to Devices for your washer and dryer and use the "Export Data" button for the Attributes and save as a CSV and attach to this post. Thanks

Attached both attributes and commands as jsons for all 3 of my samsung devices hopefully that helps you out. The HA core integration has good data from the WM and TD already so if you forked that then I doubt it will be a problem. Just the ability to see fridge settings as entities is exciting!

Getting ahead of myself but will you consider a PR to HA core when tested?

Fridge - Device Attributes.json Washing Machine - Device Attributes.json Tumble Dryer - Device Attributes.json Tumble Dryer - Device Commands.json Washing Machine - Device Commands.json Fridge - Device Commands.json

bakernigel commented 1 day ago

@SGXander Your fridge is very similar to mine, so I think it should be fine. The washer and dryer have all capabilities under the main component which as you said the original integration and mine will handle. However I see they have a lot of custom. and samscungce. capabilities which I assume do not show in the core integration. These will not show in my integration either unless I add them. The issue I have making my version the core version is that Smarthings supports so many different devices, not just Samsung, and I think I might spend the rest of my life fixing issues with devices I don't have ! Maybe making it an official HACS integration would be the next step.

SGXander commented 15 hours ago

@SGXander Your fridge is very similar to mine, so I think it should be fine. The washer and dryer have all capabilities under the main component which as you said the original integration and mine will handle. However I see they have a lot of custom. and samscungce. capabilities which I assume do not show in the core integration. These will not show in my integration either unless I add them. The issue I have making my version the core version is that Smarthings supports so many different devices, not just Samsung, and I think I might spend the rest of my life fixing issues with devices I don't have ! Maybe making it an official HACS integration would be the next step.

As it is there's no response so providing support for the fridge would be a huge help. you could do a PR for the fridge components but ask HA not to cite you as a new maintainer?

joostlek commented 15 hours ago

@bakernigel I can understand that you don't want to be the sole maintainer, but since SmartThings is quite complex compared to other integrations, someone who can help reviewing if the changes make sense are also welcome. Nobody will blame you for not being able to maintain every device :)