home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
71.16k stars 29.85k forks source link

Missing temp_step parameter for MQTT water_heater #105172

Closed cociweb closed 9 months ago

cociweb commented 9 months ago

The problem

MQTT Water_heater integration is added in 2023 but somehow the temp_step parameter is left out. Based on the MQTT HVAC(climate) integration this parameter should be a float and by-default=1. This is important parameter to control the unit. (The precision parameter should be[is?] related only in the value indication.)

What version of Home Assistant Core has the issue?

core-2023.07.0

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Core

Integration causing the issue

MQTT Water Heater

Link to integration documentation on our website

https://www.home-assistant.io/integrations/water_heater.mqtt

Diagnostics information

No response

Example YAML snippet

mqtt:
  - water_heater:
      name: Boiler
      mode_command_topic: "basement/boiler/mode/set"
      temp_step: 0.1

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 9 months ago

Hey there @emontnemery, @jbouwh, mind taking a look at this issue as it has been labeled with an integration (mqtt) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `mqtt` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign mqtt` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


mqtt documentation mqtt source (message by IssueLinks)

cociweb commented 9 months ago

Let me add @hookedonunix as the original feature implementation is done here: https://github.com/home-assistant/core/pull/93644

jbouwh commented 9 months ago

The setting you are refering too is linked to is _attr_target_temperature_step. it is implemented for the core climate component, but documented, it is missing in the water_heater component. So this was never implemented in the core component neither documented. It needs an architectural discussion with a decision to add it.

jbouwh commented 9 months ago

Opened a PR to add the property to the climate entity developer docs: https://github.com/home-assistant/developers.home-assistant/pull/2001

To open an architectural discussion on implementing target_temperature_step you can start a discussion here: https://github.com/home-assistant/architecture/discussions

jbouwh commented 9 months ago

As this is not an issue, but a feature request, I need to close this, as it is not an issue with Home Assistant.