search

home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
71.74k stars 29.99k forks source link

Tado integration wrong debug log lines #107082

Closed snakuzzo closed 8 months ago

snakuzzo commented 8 months ago

The problem

After 2024.1 update, there are DEBUG pyTado log lines In log file

What version of Home Assistant Core has the issue?

core-2024.1.0

What was the last working version of Home Assistant Core?

core-2023.12.4

What type of installation are you running?

Home Assistant Container

Integration causing the issue

Tado

Link to integration documentation on our website

https://www.home-assistant.io/integrations/tado/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

These log lines are present in log file but not in exported diagnostic data

PyTado.http.http :: DEBUG    :: 
Request:
    Method:POST
    URL: https://auth.tado.com/oauth/token<MASKED>
    Headers: {'User-Agent': 'python-requests/2.31.0', 'Accept-Encoding': 'gzip, deflate, br', 'Accept': '*/*', 'Connection': 'keep-alive', 'Content-Type': 'application/json', 'Referer': 'https://app.tado.com/', 'Content-Length': '2'}
Response:
    StatusCode: 200
    Data: {<MASKED>, 'token_type': 'bearer', <MASKED>, 'expires_in': 599, 'scope': 'home.user', 'jti': '09df74dd-dfaa-420c-989b-16a1b0024065'}
PyTado.http.http :: DEBUG    :: 
Request:
    Method:POST
    URL: https://auth.tado.com/oauth/token<MASKED>
    Headers: {'User-Agent': 'python-requests/2.31.0', 'Accept-Encoding': 'gzip, deflate, br', 'Accept': '*/*', 'Connection': 'keep-alive', 'Content-Type': 'application/json', 'Referer': 'https://app.tado.com/', 'Content-Length': '2'}
Response:
    StatusCode: 200
    Data: {<MASKED>, 'token_type': 'bearer', <MASKED>, 'expires_in': 599, 'scope': 'home.user', 'jti': '02d48c2d-e4fe-45d2-981c-cd93b2f2172e'}
PyTado.http.http :: DEBUG    :: 
Request:
    Method:POST
    URL: https://auth.tado.com/oauth/token<MASKED>
    Headers: {'User-Agent': 'python-requests/2.31.0', 'Accept-Encoding': 'gzip, deflate, br', 'Accept': '*/*', 'Connection': 'keep-alive', 'Content-Type': 'application/json', 'Referer': 'https://app.tado.com/', 'Content-Length': '2'}
Response:
    StatusCode: 200
    Data: {<MASKED>, 'token_type': 'bearer', <MASKED>, 'expires_in': 599, 'scope': 'home.user', 'jti': 'ce34c52f-6d88-45ef-991d-6b988bd84541'}


### Additional information

_No response_
home-assistant[bot] commented 8 months ago

Hey there @michaelarnauts, @chiefdragon, @erwindouna, mind taking a look at this issue as it has been labeled with an integration (tado) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `tado` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign tado` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)

tado documentation tado source (message by IssueLinks)

erwindouna commented 8 months ago

Thanks for reporting. Just a quick check: the debut logging is enabled or disabled for Tado? Also, can you send the log lines before and after the log you submitted. This might help me to pinpoint where this log is envoked.

snakuzzo commented 8 months ago

I have no active debug log on core...

image

logger in configuration.yaml

logger:
  default: warning

and this is my entire log

s6-rc: info: service s6rc-oneshot-runner: starting
s6-rc: info: service s6rc-oneshot-runner successfully started
s6-rc: info: service fix-attrs: starting
s6-rc: info: service fix-attrs successfully started
s6-rc: info: service legacy-cont-init: starting
s6-rc: info: service legacy-cont-init successfully started
s6-rc: info: service legacy-services: starting
services-up: info: copying legacy longrun home-assistant (no readiness notification)
s6-rc: info: service legacy-services successfully started
2024-01-04 09:48:53.458 WARNING (SyncWorker_0) [homeassistant.loader] We found a custom integration smartthinq_sensors which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant
2024-01-04 09:48:53.459 WARNING (SyncWorker_0) [homeassistant.loader] We found a custom integration skyq which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant
2024-01-04 09:48:53.460 WARNING (SyncWorker_0) [homeassistant.loader] We found a custom integration spook which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant
2024-01-04 09:48:53.461 WARNING (SyncWorker_0) [homeassistant.loader] We found a custom integration spook_inverse which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant
PyTado.http.http :: DEBUG    :: 
Request:
    Method:POST
    URL: https://auth.tado.com/oauth/token<MASKED>
    Headers: {'User-Agent': 'python-requests/2.31.0', 'Accept-Encoding': 'gzip, deflate, br', 'Accept': '*/*', 'Connection': 'keep-alive', 'Content-Type': 'application/json', 'Referer': 'https://app.tado.com/', 'Content-Length': '2'}
Response:
    StatusCode: 200
    Data: {<MASKED>, 'token_type': 'bearer', <MASKED>, 'expires_in': 599, 'scope': 'home.user', 'jti': '90eb8118-2ab5-4399-9905-5f1600b74d87'}
2024-01-04 09:49:19.807 WARNING (MainThread) [snakuzzo.logger] Home Assistant Started!
PyTado.http.http :: DEBUG    :: 
Request:
    Method:POST
    URL: https://auth.tado.com/oauth/token<MASKED>
    Headers: {'User-Agent': 'python-requests/2.31.0', 'Accept-Encoding': 'gzip, deflate, br', 'Accept': '*/*', 'Connection': 'keep-alive', 'Content-Type': 'application/json', 'Referer': 'https://app.tado.com/', 'Content-Length': '2'}
Response:
    StatusCode: 200
    Data: {<MASKED>, 'token_type': 'bearer', <MASKED>, 'expires_in': 599, 'scope': 'home.user', 'jti': '09df74dd-dfaa-420c-989b-16a1b0024065'}
PyTado.http.http :: DEBUG    :: 
Request:
    Method:POST
    URL: https://auth.tado.com/oauth/token<MASKED>
    Headers: {'User-Agent': 'python-requests/2.31.0', 'Accept-Encoding': 'gzip, deflate, br', 'Accept': '*/*', 'Connection': 'keep-alive', 'Content-Type': 'application/json', 'Referer': 'https://app.tado.com/', 'Content-Length': '2'}
Response:
    StatusCode: 200
    Data: {<MASKED>, 'token_type': 'bearer', <MASKED>, 'expires_in': 599, 'scope': 'home.user', 'jti': '02d48c2d-e4fe-45d2-981c-cd93b2f2172e'}
PyTado.http.http :: DEBUG    :: 
Request:
    Method:POST
    URL: https://auth.tado.com/oauth/token<MASKED>
    Headers: {'User-Agent': 'python-requests/2.31.0', 'Accept-Encoding': 'gzip, deflate, br', 'Accept': '*/*', 'Connection': 'keep-alive', 'Content-Type': 'application/json', 'Referer': 'https://app.tado.com/', 'Content-Length': '2'}
Response:
    StatusCode: 200
    Data: {<MASKED>, 'token_type': 'bearer', <MASKED>, 'expires_in': 599, 'scope': 'home.user', 'jti': 'ce34c52f-6d88-45ef-991d-6b988bd84541'}
PyTado.http.http :: DEBUG    :: 
Request:
    Method:POST
    URL: https://auth.tado.com/oauth/token<MASKED>
    Headers: {'User-Agent': 'python-requests/2.31.0', 'Accept-Encoding': 'gzip, deflate, br', 'Accept': '*/*', 'Connection': 'keep-alive', 'Content-Type': 'application/json', 'Referer': 'https://app.tado.com/', 'Content-Length': '2'}
Response:
    StatusCode: 200
    Data: {<MASKED>, 'token_type': 'bearer', <MASKED>, 'expires_in': 599, 'scope': 'home.user', 'jti': 'dab2507b-ef5b-4ba5-8172-4a2bb1e01848'}
PyTado.http.http :: DEBUG    :: 
Request:
    Method:POST
    URL: https://auth.tado.com/oauth/token<MASKED>
    Headers: {'User-Agent': 'python-requests/2.31.0', 'Accept-Encoding': 'gzip, deflate, br', 'Accept': '*/*', 'Connection': 'keep-alive', 'Content-Type': 'application/json', 'Referer': 'https://app.tado.com/', 'Content-Length': '2'}
Response:
    StatusCode: 200
    Data: {<MASKED>, 'token_type': 'bearer', <MASKED>, 'expires_in': 599, 'scope': 'home.user', 'jti': '9fe00730-08a1-4613-ab2b-5cf869183053'}
PyTado.http.http :: DEBUG    :: 
Request:
    Method:POST
    URL: https://auth.tado.com/oauth/token<MASKED>
    Headers: {'User-Agent': 'python-requests/2.31.0', 'Accept-Encoding': 'gzip, deflate, br', 'Accept': '*/*', 'Connection': 'keep-alive', 'Content-Type': 'application/json', 'Referer': 'https://app.tado.com/', 'Content-Length': '2'}
Response:
    StatusCode: 200
    Data: {<MASKED>, 'token_type': 'bearer', <MASKED>, 'expires_in': 599, 'scope': 'home.user', 'jti': 'b87b2bad-2b23-486f-9395-d92527eaf7d9'}
PyTado.http.http :: DEBUG    :: 
Request:
    Method:POST
    URL: https://auth.tado.com/oauth/token<MASKED>
    Headers: {'User-Agent': 'python-requests/2.31.0', 'Accept-Encoding': 'gzip, deflate, br', 'Accept': '*/*', 'Connection': 'keep-alive', 'Content-Type': 'application/json', 'Referer': 'https://app.tado.com/', 'Content-Length': '2'}
Response:
    StatusCode: 200
    Data: {<MASKED>, 'token_type': 'bearer', <MASKED>, 'expires_in': 599, 'scope': 'home.user', 'jti': '9cf7377b-b30f-452c-9eb1-9a0f666b5aa7'}
PyTado.http.http :: DEBUG    :: 
Request:
    Method:POST
    URL: https://auth.tado.com/oauth/token<MASKED>
    Headers: {'User-Agent': 'python-requests/2.31.0', 'Accept-Encoding': 'gzip, deflate, br', 'Accept': '*/*', 'Connection': 'keep-alive', 'Content-Type': 'application/json', 'Referer': 'https://app.tado.com/', 'Content-Length': '2'}
Response:
    StatusCode: 200
    Data: {<MASKED>, 'token_type': 'bearer', <MASKED>, 'expires_in': 599, 'scope': 'home.user', 'jti': '3932c4a7-8d72-423d-a61f-afd91f25826b'}
PyTado.http.http :: DEBUG    :: 
Request:
    Method:POST
    URL: https://auth.tado.com/oauth/token<MASKED>
    Headers: {'User-Agent': 'python-requests/2.31.0', 'Accept-Encoding': 'gzip, deflate, br', 'Accept': '*/*', 'Connection': 'keep-alive', 'Content-Type': 'application/json', 'Referer': 'https://app.tado.com/', 'Content-Length': '2'}
Response:
    StatusCode: 200
    Data: {<MASKED>, 'token_type': 'bearer', <MASKED>, 'expires_in': 599, 'scope': 'home.user', 'jti': '494eedc8-e199-4f33-ab97-2da9ad10b060'}
PyTado.http.http :: DEBUG    :: 
Request:
    Method:POST
    URL: https://auth.tado.com/oauth/token<MASKED>
    Headers: {'User-Agent': 'python-requests/2.31.0', 'Accept-Encoding': 'gzip, deflate, br', 'Accept': '*/*', 'Connection': 'keep-alive', 'Content-Type': 'application/json', 'Referer': 'https://app.tado.com/', 'Content-Length': '2'}
Response:
    StatusCode: 200
    Data: {<MASKED>, 'token_type': 'bearer', <MASKED>, 'expires_in': 599, 'scope': 'home.user', 'jti': '46561676-75e3-4eb1-a56d-5445d66901c8'}
PyTado.http.http :: DEBUG    :: 
Request:
    Method:POST
    URL: https://auth.tado.com/oauth/token<MASKED>
    Headers: {'User-Agent': 'python-requests/2.31.0', 'Accept-Encoding': 'gzip, deflate, br', 'Accept': '*/*', 'Connection': 'keep-alive', 'Content-Type': 'application/json', 'Referer': 'https://app.tado.com/', 'Content-Length': '2'}
Response:
    StatusCode: 200
    Data: {<MASKED>, 'token_type': 'bearer', <MASKED>, 'expires_in': 599, 'scope': 'home.user', 'jti': 'f55d81a3-8bae-425b-9721-1771827a7a61'}
KC-inDomus commented 8 months ago

+1

erwindouna commented 8 months ago

I think I spotted this issue. Thanks!

erwindouna commented 8 months ago

The issue is related to a change implemented later on in PyTado. They were missing the debug parameter in the HTTP class used to utilizes OAuth. The workaround for Home Assistant will be to bump the version to PyTado 0.17.2. I will create a PR for this get this resolved as soon as possible.

erwindouna commented 8 months ago

As a side note: I have requested them to release it on PyPi. The latest version there is only 0.17.

wmalgadey commented 8 months ago

0.17.3 is released

erwindouna commented 8 months ago

0.17.3 is released

Thanks! Much appreciated. I will prepare a PR to fix this with dependency bump in Home Assistant.