home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
70.45k stars 29.38k forks source link

Roomba integration not handling bag full on charging base (Error 216) #108169

Closed jantman closed 3 weeks ago

jantman commented 7 months ago

The problem

I have an iRobot Roomba s9+ with the charging base that automatically empties the robot's bin into a bag in the charging base. The bag just filled up for the first time since I've integrated it with HASS, and it is currently showing in "Paused" state. However the device attributes list an error code of 216. HASS error logs include:

WARNING (Thread-10 (_thread_main)) [roombapy.roomba] Error looking up Roomba error message: 216

The roomba integration and its underlying roombapy library do not seem to support this, but the separate Roomba980-Python project confirms that error 216 indicates "charging base bag full". I've been unable to find any information on decoding the supported_features attribute that's exposed, but for my robot it is 13180.

What version of Home Assistant Core has the issue?

2024.1.2

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Container

Integration causing the issue

roomba

Link to integration documentation on our website

https://www.home-assistant.io/integrations/roomba

Diagnostics information

vacuum.roomba current entity attributes:

fan_speed_list: Automatic, Eco, Performance
battery_level: 34
battery_icon: mdi:battery-30
fan_speed: Automatic
software_version: soho+22.29.10+2023-10-09-2b3f87f75e8+Firmware-Build+4863
status: Paused
error: Unknown Error number: 216
error_code: 216
bin_present: true
bin_full: true
friendly_name: Roomba
supported_features: 13180

Example YAML snippet

No response

Anything in the logs that might be useful for us?

Jan 16 10:20:30 nuc1 docker-hass[2688383]: 2024-01-16 10:20:30.082 WARNING (MainThread) [homeassistant.components.automation.roomba_status_change] roomba-status-change: Already running
Jan 16 10:20:56 nuc1 docker-hass[2688383]: 2024-01-16 10:20:56.853 WARNING (Thread-10 (_thread_main)) [roombapy.roomba] Error looking up Roomba error message: 216
Jan 16 10:20:57 nuc1 docker-hass[2688383]: 2024-01-16 10:20:57.032 WARNING (Thread-10 (_thread_main)) [roombapy.roomba] Error looking up Roomba error message: 216
Jan 16 10:20:57 nuc1 docker-hass[2688383]: 2024-01-16 10:20:57.034 WARNING (Thread-10 (_thread_main)) [roombapy.roomba] Error looking up Roomba error message: 216

Additional information

I've turned on debug logging for the integration for about an hour after this happened, but that hasn't shown anything new other than wifistat messages.

I have decent Python skills and am willing to help implement a fix or assist with testing, but I have no experience with HASS integration development and also don't know how this should be handled inside the integration, as it appears to be an error code rather than a state, and it looks like this integration doesn't really handle errors beyond setting them as a state attribute?

home-assistant[bot] commented 7 months ago

Hey there @pschmitt, @cyr-ius, @shenxn, @xitee1, mind taking a look at this issue as it has been labeled with an integration (roomba) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `roomba` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign roomba` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


roomba documentation roomba source (message by IssueLinks)

issue-triage-workflows[bot] commented 4 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

jantman commented 4 months ago

This is still valid on 2024.4.1

issue-triage-workflows[bot] commented 1 month ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.