home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
71.72k stars 29.98k forks source link

Hard-coded Home Connect domain caused lack-of-cover of Bosch & Siemens electrons located in China #109090

Closed Astrian closed 4 months ago

Astrian commented 7 months ago

The problem

Tag: integration: home_connect

In China, there is a dedicated Home Connect server called “晶御智能” and have dedicated API endpoint domain api.home-connect.cn. The explanation is shown in their document:

Two dedicated Home Connect instance have same API endpoints and sharing same API keys which has clicked “Sync To China” switch on the development dashboard on Home Connect.

The switch of Sync To China

However, the Home Connect instance domain is hard-coded in the source code of Home Assistant Core.

User can manually set the domain of OAuth webpage to api.home-connect.cn and fully compatible with the OAuth authentication endpoints of the main fork.

OAuth page of Home Connect China

But the callback will cause Home Assistant to failed to fetch access token.

Error returned by Home Assistant

What version of Home Assistant Core has the issue?

core-2024.1.5

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Container

Integration causing the issue

No response

Link to integration documentation on our website

https://www.home-assistant.io/integrations/home_connect

Diagnostics information

Same issue on this community post: https://community.home-assistant.io/t/home-connect-special-setiings-for-china/508494

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 7 months ago

Hey there @davidmstraub, mind taking a look at this issue as it has been labeled with an integration (home_connect) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `home_connect` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign home_connect` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


home_connect documentation home_connect source (message by IssueLinks)

issue-triage-workflows[bot] commented 4 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.