Space API: Add support for SpaceAPI v14

miko007 commented 7 months ago

The problem

SpaceAPI version 14 has been released in 2020, the Home Assistant core integration still does only support version 13, which is more than eleven years old by now.

It especially allows for custom attributes when prefixed with the ext_ prefix. Also, many attributes have been shifted around and modified.

What version of Home Assistant Core has the issue?

core-2024.1.5

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Container

Integration causing the issue

spaceapi

Link to integration documentation on our website

https://www.home-assistant.io/integrations/spaceapi/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 7 months ago

Hey there @fabaff, mind taking a look at this issue as it has been labeled with an integration (spaceapi) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of `spaceapi` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign spaceapi` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

_{^{(message by CodeOwnersMention)}}

spaceapi documentation spaceapi source _{^{(message by IssueLinks)}}

codyc1515 commented 7 months ago

This shounds like an enhancement which should be raised in the Community under Feature Requests.

miko007 commented 7 months ago

This shounds like an enhancement which should be raised in the Community under Feature Requests.

you could argue that. you could also argue, that being four years behind on the specification is a bug.

stefanheinrichsen commented 6 months ago

@miko007 Do you have any overview what about the differences/changes between v13 and v14?

fabaff commented 6 months ago

One reason this was never updated to v14 was the introduced requirement to have config flows for the integrations. The visual representation of the config flow was not designed to enter a large amount of data which would happen if the users want to go beyond a minimal configuration for the SpaceAPI.

miko007 commented 6 months ago

@stefanheinrichsen here is a diff: https://www.diffchecker.com/sfLsruDN/

or you take a look at the specification yourself.

miko007 commented 6 months ago

@fabaff wouldn't it be possible to just ask for the basic information like name, address and logo in the config flow and then implement the input of other information on another screen somewhere?

issue-triage-workflows[bot] commented 3 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

fabaff commented 3 months ago

@fabaff wouldn't it be possible to just ask for the basic information like name, address and logo in the config flow and then implement the input of other information on another screen somewhere?

Would be possible I guess.

issue-triage-workflows[bot] commented 1 week ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

miko007 commented 3 days ago

this is still relevant, i guess...

home-assistant / core