home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
71.26k stars 29.85k forks source link

Bond Bridge fireplace created as a light rather than a switch #109671

Open blueyetisoftware-jason opened 7 months ago

blueyetisoftware-jason commented 7 months ago

The problem

When using the Bond integration for a fireplace, the fireplace on/off is created as a light rather than a switch. This results in some implicit behavior intended for lights. As an example, if the devices are bridged to HomeKit, they are turned on and off with all other lights. As a switch, the user would decide to treat the fireplace as a light, switch, or fan, and group it with other climate control devices rather than lights. Many fireplaces also have secondary accent lights and circulation fans, so treating the main fireplace heat source as a "switch" makes the most sense.

Since a fireplace is a heat control device, it doesn't seem appropriate to assign it "light" as a device class. It is more of an appliance. Switch provides a better device class for representing the fireplace.

What version of Home Assistant Core has the issue?

core-2024.1.6

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Bond

Link to integration documentation on our website

https://www.home-assistant.io/integrations/bond

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 7 months ago

Hey there @bdraco, @prystupa, @joshs85, @marciogranzotto, mind taking a look at this issue as it has been labeled with an integration (bond) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `bond` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign bond` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


bond documentation bond source (message by IssueLinks)

blueyetisoftware-jason commented 7 months ago

As a workaround, I created a template switch that mimicked the light that was created, but this integration would be cleaner as a switch out of the box. Thanks for taking a look at it.

issue-triage-workflows[bot] commented 4 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

blueyetisoftware-jason commented 4 months ago

I'd still recommend changing the type of the device

issue-triage-workflows[bot] commented 1 month ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

blueyetisoftware-jason commented 1 month ago

Please don't make me stale :) This would just be a type change from light to switch. Should be pretty straight forward. Fireplaces shouldn't be lights, but if it is a switch, the user could always choose to display it as a light if they insist on it.