home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
72.8k stars 30.5k forks source link

Roomba Locate throws error #11006

Closed xstrex closed 6 years ago

xstrex commented 6 years ago

Make sure you are running the latest version of Home Assistant before reporting an issue.

You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:

Home Assistant release (hass --version): 0.59.1

Python release (python3 --version): 3.5.2

Component/platform: iRobot Roomba

Description of problem: Calling "Roomba Locate" throws error in logs, and doesn't actually locate roomba (play sound on roomba)

Expected: Roomba should play locate tone

Problem-relevant configuration.yaml entries and steps to reproduce:

vacuum:
  - platform: roomba
    host: !secret roomba_host
    username: !secret roomba_user
    password: !secret roomba_pass
    name: vacuum
  1. add roomba component
  2. Call service: vacuum.locate entity_id: vacuum.vacuum
  3. No tone from roomba / error in log

Traceback (if applicable):

2017-12-06 20:36:38 ERROR (MainThread) [homeassistant.core] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/lib/python3.5/asyncio/tasks.py", line 241, in _step
    result = coro.throw(exc)
  File "/usr/local/lib/python3.5/dist-packages/homeassistant/core.py", line 1031, in _event_to_service_call
    yield from service_handler.func(service_call)
  File "/usr/local/lib/python3.5/dist-packages/homeassistant/components/vacuum/__init__.py", line 200, in async_handle_vacuum_service
    yield from getattr(vacuum, method['method'])(**params)
  File "/usr/lib/python3.5/asyncio/futures.py", line 361, in __iter__
    yield self  # This tells Task to wait for completion.
  File "/usr/lib/python3.5/asyncio/tasks.py", line 296, in _wakeup
    future.result()
  File "/usr/lib/python3.5/asyncio/futures.py", line 274, in result
    raise self._exception
  File "/usr/lib/python3.5/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/lib/python3.5/dist-packages/homeassistant/components/vacuum/__init__.py", line 330, in locate
    raise NotImplementedError()
NotImplementedError

Additional info:

balloobbot commented 6 years ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.

Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment :+1:

xstrex commented 6 years ago

hass --version 0.65.4 python3 --version 3.6.3

problem:

  1. add roomba component
  2. Call service: vacuum.locate entity_id: vacuum.vacuum
  3. No tone from roomba / error in log
2018-03-15 16:18:16 ERROR (MainThread) [homeassistant.core] Error executing service <ServiceCall vacuum.locate: entity_id=['vacuum.newt']>
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/homeassistant/core.py", line 1006, in _event_to_service_call
    await service_handler.func(service_call)
  File "/usr/local/lib/python3.6/dist-packages/homeassistant/components/vacuum/__init__.py", line 194, in async_handle_vacuum_service
    yield from getattr(vacuum, method['method'])(**params)
  File "/usr/lib/python3.6/asyncio/futures.py", line 332, in __iter__
    yield self  # This tells Task to wait for completion.
  File "/usr/lib/python3.6/asyncio/tasks.py", line 250, in _wakeup
    future.result()
  File "/usr/lib/python3.6/asyncio/futures.py", line 245, in result
    raise self._exception
  File "/usr/lib/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/lib/python3.6/dist-packages/homeassistant/components/vacuum/__init__.py", line 324, in locate
    raise NotImplementedError()
NotImplementedError
MartinHjelmare commented 6 years ago

The locate service is not implemented yet for the roomba vacuum platform.