search

home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
72.8k stars 30.5k forks source link

iRobot Roomba and Braava Integration doesn't work after update to 2024.2.3 #111210

Closed HaraldGithub closed 8 months ago

HaraldGithub commented 8 months ago

The problem

After Updating via terminal from 2024.2.2 to 2024.2.3 "iRobot Roomba and Braava"-Integration doesn't work any longer. All devices and entoties are unavailable. Reload integration and restart HA with hardware doesn't help

I'm back to 2024.2.2 an "iRobot Roomba and Braava"-Integration works again.

What version of Home Assistant Core has the issue?

2024.2.3

What was the last working version of Home Assistant Core?

2024.2.2

What type of installation are you running?

Home Assistant Supervised

Integration causing the issue

iRobot Roomba and Braava

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

craigccfl commented 8 months ago

How are you manually bumping it? Custom deps deployment then putting roombapy==1.6.13 in pypi?

Download 1.6.13, place the roombapy folder from inside the zip in HA's /config, restart HA.

Here is the link to 1.6.13 https://github.com/pschmitt/roombapy/archive/refs/tags/1.6.13.zip

Once 1.6.13 is merged into HA releases (hopefully in 2024.3), you can delete the folder

Thanks @gkwok1 | Fixed me right up once I figured out, not to copy the whole git folder into HA/config. Update to previous Instructions, unzip the downloaded file, CD into the unzipped roombapy-1.6.13 folder then copy the roombapy folder in to the HA/config: restart.

Learned something new today. Thanks all. 👍

Dystaxia commented 8 months ago

How are you manually bumping it? Custom deps deployment then putting roombapy==1.6.13 in pypi?

Download 1.6.13, place the roombapy folder from inside the zip in HA's /config, restart HA. Here is the link to 1.6.13 https://github.com/pschmitt/roombapy/archive/refs/tags/1.6.13.zip Once 1.6.13 is merged into HA releases (hopefully in 2024.3), you can delete the folder

Thanks @gkwok1 | Fixed me right up once I figured out, not to copy the whole git folder into HA/config. Update to previous Instructions, unzip the downloaded file, CD into the unzipped roombapy-1.6.13 folder then copy the roombapy folder in to the HA/config: restart.

Learned something new today. Thanks all. 👍

That was easy... thanks!

craigccfl commented 8 months ago

How are you manually bumping it? Custom deps deployment then putting roombapy==1.6.13 in pypi?

Download 1.6.13, place the roombapy folder from inside the zip in HA's /config, restart HA. Here is the link to 1.6.13 https://github.com/pschmitt/roombapy/archive/refs/tags/1.6.13.zip Once 1.6.13 is merged into HA releases (hopefully in 2024.3), you can delete the folder

Thanks @gkwok1 | Fixed me right up once I figured out, not to copy the whole git folder into HA/config. Update to previous Instructions, unzip the downloaded file, CD into the unzipped roombapy-1.6.13 folder then copy the roombapy folder in to the HA/config: restart. Learned something new today. Thanks all. 👍

That was easy... thanks!

FYI: When I deleted the folder from the HA/config - Roomba stopped working. When I put it back, working again. I'm thinking when the Feb update rolls out, I'll delete the folder in HA then update to 2024.3 and see if it starts working as normal. IMO, probably best to update Roomba via Docker cli commands or just wait for 2024.3 😎

gkwok1 commented 8 months ago

FYI: When I deleted the folder from the HA/config - Roomba stopped working. When I put it back, working again. I'm thinking when the Feb update rolls out, I'll delete the folder in HA then update to 2024.3 and see if it starts working as normal. IMO, probably best to update Roomba via Docker cli commands or just wait for 2024.3 😎

Having the roombapy folder in HA/config will override whatever that comes with HA so it will not work if you delete it after getting it working again. Leave the roombapy folder in /config until it's confirm that 1.6.13 is merged into HA's releases.

smithj33 commented 8 months ago

It's all good... it's just a sub-par vacuum in this case. I appreciate you all for the effort and work put in to make HA great. My Roomba is noisy and annoying anyway so this will be a nice quiet break :)

My dumb Shark is sitting in the corner after getting an i5, but the shark cleans so much better at half the noise level. About to dump this roomba :)

craigccfl commented 8 months ago

FYI: When I deleted the folder from the HA/config - Roomba stopped working. When I put it back, working again. I'm thinking when the Feb update rolls out, I'll delete the folder in HA then update to 2024.3 and see if it starts working as normal. IMO, probably best to update Roomba via Docker cli commands or just wait for 2024.3 😎

Having the roombapy folder in HA/config will override whatever that comes with HA so it will not work if you delete it after getting it working again. Leave the roombapy folder in /config until it's confirm that 1.6.13 is merged into HA's releases.

Kinda figured that, thanks @gkwok1

cristianmarino commented 8 months ago

Dear, I guess I got same problem:

HA OS Core: 2024.2.3 Supervisor: 2024.02.0 Operating System: 11.5 Frontend: 20240207.1

2024-02-25 23:32:13.145 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry Alfred for roomba Traceback (most recent call last): File "/usr/src/homeassistant/homeassistant/config_entries.py", line 444, in async_setup result = await component.async_setup_entry(hass, self) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/src/homeassistant/homeassistant/components/roomba/init.py", line 40, in async_setup_entry roomba = await hass.async_add_executor_job( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/concurrent/futures/thread.py", line 58, in run result = self.fn(*self.args, *self.kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/site-packages/roombapy/roomba_factory.py", line 14, in create_roomba remote_client = RoombaFactory._create_remote_client( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/site-packages/roombapy/roomba_factory.py", line 21, in _create_remote_client return RoombaRemoteClient(address=address, blid=blid, password=password) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/site-packages/roombapy/remote_client.py", line 44, in init self.mqtt_client = self._get_mqtt_client() ^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/site-packages/roombapy/remote_client.py", line 103, in _get_mqtt_client callback_api_version=mqtt.CallbackAPIVersion.VERSION1, ^^^^^^^^^^^^^^^^^^^^^^^ AttributeError: module 'paho.mqtt.client' has no attribute 'CallbackAPIVersion' 2024-02-25 23:32:15.193 WARNING (MainThread) [homeassistant.components.sensor] Setup of sensor platform rest is taking over 10 seconds. 2024-02-25 23:32:29.764 WARNING (SyncWorker_2) [scapy.runtime] Interface vetheac6734 does not exist! 2024-02-25 23:48:10.578 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry Alfred for roomba Traceback (most recent call last): File "/usr/src/homeassistant/homeassistant/config_entries.py", line 444, in async_setup result = await component.async_setup_entry(hass, self) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/src/homeassistant/homeassistant/components/roomba/init.py", line 40, in async_setup_entry roomba = await hass.async_add_executor_job( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/concurrent/futures/thread.py", line 58, in run result = self.fn(self.args, **self.kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/site-packages/roombapy/roomba_factory.py", line 14, in create_roomba remote_client = RoombaFactory._create_remote_client( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/site-packages/roombapy/roomba_factory.py", line 21, in _create_remote_client return RoombaRemoteClient(address=address, blid=blid, password=password) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/site-packages/roombapy/remote_client.py", line 44, in init self.mqtt_client = self._get_mqtt_client() ^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/site-packages/roombapy/remote_client.py", line 103, in _get_mqtt_client callback_api_version=mqtt.CallbackAPIVersion.VERSION1, ^^^^^^^^^^^^^^^^^^^^^^^ AttributeError: module 'paho.mqtt.client' has no attribute 'CallbackAPIVersion'

jurgenweber commented 8 months ago

Dear, I guess I got same problem:

HA OS Core: 2024.2.3 Supervisor: 2024.02.0 Operating System: 11.5 Frontend: 20240207.1

2024-02-25 23:32:13.145 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry Alfred for roomba Traceback (most recent call last): File "/usr/src/homeassistant/homeassistant/config_entries.py", line 444, in async_setup result = await component.async_setup_entry(hass, self) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/src/homeassistant/homeassistant/components/roomba/init.py", line 40, in async_setup_entry roomba = await hass.async_add_executor_job( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/concurrent/futures/thread.py", line 58, in run result = self.fn(*self.args, self.kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/site-packages/roombapy/roomba_factory.py", line 14, in create_roomba remote_client = RoombaFactory._create_remote_client( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/site-packages/roombapy/roomba_factory.py", line 21, in _create_remote_client return RoombaRemoteClient(address=address, blid=blid, password=password) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/site-packages/roombapy/remote_client.py", line 44, in init self.mqtt_client = self._get_mqtt_client() ^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/site-packages/roombapy/remote_client.py", line 103, in _get_mqtt_client callback_api_version=mqtt.CallbackAPIVersion.VERSION1, ^^^^^^^^^^^^^^^^^^^^^^^ AttributeError: module 'paho.mqtt.client' has no attribute 'CallbackAPIVersion' 2024-02-25 23:32:15.193 WARNING (MainThread) [homeassistant.components.sensor] Setup of sensor platform rest is taking over 10 seconds. 2024-02-25 23:32:29.764 WARNING (SyncWorker_2) [scapy.runtime] Interface vetheac6734 does not exist! 2024-02-25 23:48:10.578 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry Alfred for roomba Traceback (most recent call last): File "/usr/src/homeassistant/homeassistant/config_entries.py", line 444, in async_setup result = await component.async_setup_entry(hass, self) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/src/homeassistant/homeassistant/components/roomba/init*.py", line 40, in async_setup_entry roomba = await hass.async_add_executor_job( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/concurrent/futures/thread.py", line 58, in run result = self.fn(self.args, self.kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/site-packages/roombapy/roomba_factory.py", line 14, in create_roomba remote_client = RoombaFactory._create_remote_client( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/site-packages/roombapy/roomba_factory.py", line 21, in _create_remote_client return RoombaRemoteClient(address=address, blid=blid, password=password) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/site-packages/roombapy/remote_client.py", line 44, in init** self.mqtt_client = self._get_mqtt_client() ^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/site-packages/roombapy/remote_client.py", line 103, in _get_mqtt_client callback_api_version=mqtt.CallbackAPIVersion.VERSION1, ^^^^^^^^^^^^^^^^^^^^^^^ AttributeError: module 'paho.mqtt.client' has no attribute 'CallbackAPIVersion'

are you running core yourself? refer to my post you need to change the manifest as well as update the pip version:

RUN sed -i 's/1.6.12/1.6.13/g' /usr/src/homeassistant/homeassistant/components/roomba/manifest.json && pip install roombapy==1.6.13

IF you do not change the manifest, somewhere along the line HASS reverts.

This is just a vacuum, just wait for the fix, also there are other options you can use in the meantime to use the robot, the official app or even the physical buttons, I do think people are overreacting, there is no guarantee nowhere these integrations will work 100% of the time, accept that and move on 😄

home assistant team, you are doing great and we appreciate your hard work and transparency

I would argue it is not just a vacuum, ensuring the place is vacuum'd is heavily tied to the 'WAF' (Wife Acceptance Factor) and if it isn't working I loose my HASS budget, happy wife, happy life and so on.

To be fair, I get both sides as I work on both sides but I don't see any harm or problem with putting in a little more effort into the hotfix pipeline so you can push those out at a higher rate and satisfy both worlds and ideally not a discussion for this thread.

Thanks again, I got it patched as per my post and I can hear my vacuum's going at full speed and the wife is happy. :P

balloob commented 8 months ago

Closing this issue as it has been resolved in #111187 and as has been stated, it will be in the next hot fix release.

People are talking in this thread like this has been broken for weeks or months and the team is not interested in addressing this, but … it's only been broken since last Thursday. The fix has been merged and it will be in a next hot fix release. It's weekend. Everyone needs to chill out.

I also see some people reference WAF. Please note, we don't use that term in in the Home Assistant community. Instead, we use the term Home Approval Factor.

I am going to also lock this issue as it seems like some people want to attack the volunteers on this integration personally, and that's not acceptable.

Happy Sunday everyone.