home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.38k stars 30.64k forks source link

Denon AVR integration takes a long time to load - part two #112063

Open pimw1 opened 8 months ago

pimw1 commented 8 months ago

The problem

Hi,

This is a follow-up of Denon AVR integration takes a long time to load. This is not related to the beta of home assistant, since this is a long standing issue.

It's regarding the Denon AVR 2312. Reason for reporting this again, is because of the upcoming release of Home Assistant 2024.3, in which integration startup times are improved a lot. Those improvements are not applicable to the Denon integration, because the root cause is different (see issue #51513): the integration waits for an api-call which is invalid for my receiver; it will wait until time-out.

When comparing this to other integrations, we can conclude there is considerable room for improvement.

image

Some different strategies that are worth to consider: -store the api-call that was successful during initial setup; during reboot, only use that specific api-call -change the order at which the api calls are executed: the call http://192.168.178.7:8080/goform/Deviceinfo.xml is the cullprit here, so perhaps this one could be tried as the last one -group receivers and define the correct api call per group (might be a lot of work) -something else?

I've added the debug logs for the Denon Integration below.

What version of Home Assistant Core has the issue?

core-2024.03.b4

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Denon AVR Network Receivers

Link to integration documentation on our website

https://www.home-assistant.io/integrations/denonavr/

Diagnostics information

home-assistant_denonavr_2024-03-02T13-40-58.383Z.log

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 8 months ago

Hey there @ol-iver, @starkillerog, mind taking a look at this issue as it has been labeled with an integration (denonavr) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `denonavr` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign denonavr` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


denonavr documentation denonavr source (message by IssueLinks)

issue-triage-workflows[bot] commented 5 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

pimw1 commented 5 months ago

Bump

issue-triage-workflows[bot] commented 2 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

pimw1 commented 2 months ago

last bump from my side: i've moved over to another receiver brand. If this issue is still relevant for anyone else, feel free to chip in.

ol-iver commented 1 month ago

I can't see the 20 seconds in your logs. According to the timestamps it takes on 0.016 seconds to call http://192.168.0.32:8080/goform/Deviceinfo.xml.

2024-09-01 18:02:40.724 DEBUG (MainThread) [denonavr.decorators] Exception HTTPStatusError: Client error '403 Forbidden' for url 'http://192.168.0.32/goform/Deviceinfo.xml'
For more information check: https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/403 raised, clearing cache
2024-09-01 18:02:40.729 DEBUG (MainThread) [denonavr.foundation] Request error on port 80 when identifying receiver, device is not a avr-x receivers
...
2024-09-01 18:02:40.745 DEBUG (MainThread) [denonavr.decorators] Network error exception on request <Request('GET', 'http://192.168.0.32:8080/goform/Deviceinfo.xml')>

With the current logging it is hard to say where the 20 seconds are coming from. I'll update the logging that it is easier to find out.