home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
69.84k stars 28.95k forks source link

WLED update installs wrong WLED variant #112606

Open jonnybergdahl opened 4 months ago

jonnybergdahl commented 4 months ago

The problem

I am using the sound reactive version of WLED, but Home Assistant does not "know" that and wants to update to the latest stock version.

Obviously this breaks things and is very confusing to the user.

The update discovery needs to check if the existing firmware is non stock and not suggesting an update.

What version of Home Assistant Core has the issue?

core-2024.2.4

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

WLED

Link to integration documentation on our website

https://www.home-assistant.io/integrations/wled/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 4 months ago

Hey there @frenck, mind taking a look at this issue as it has been labeled with an integration (wled) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `wled` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign wled` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


wled documentation wled source (message by IssueLinks)

joggs commented 3 months ago

Exactly! Just experienced this by clicking update. I have the ethernet variant installed, but it seems to just install the standard variant. Fortunately I already had wifi setup as well, so I could reach it and update it with the ethernet bin without hassle.

simonlirwin commented 3 months ago

Same issue here. I clicked to update and WLED stopped working completely afterwards. I had to re-flash WLED sound reactive from scratch.

victorclaessen commented 2 months ago

Or worse, it tries to install the regular 4MB flash version on a chip with 1MB or 2MB flash and you end up with a non-functional device that you have to retrieve and re-flash via serial.

dgm commented 1 month ago

I just got sideswiped by this issue, it lost my sound reactive settings and I had to go look at my build notes to see how to set it up again after updating to the correct firmware again. I note that a couple years ago this was unsupported in issue #69549 but now that the sound reactive code is a part of the normal WLED distribution, it seems like home assistant could support it better.