home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
70.15k stars 29.18k forks source link

Overkiz fails to set up climate entity for Atlantic Excellia when the device doesn't have room sensor #112731

Closed yllar closed 4 months ago

yllar commented 4 months ago

The problem

Overkiz fails to set up climate entity. Water heater is added (can not change temperature, but that's another issue).

When I manually remove the "+ 1" from atlantic_pass_apc_heating_zone.py line 104 the climate device is set up, target temp is shown and I can change the target temp.

Firmware: C667208 Hardware: io:AtlanticPassAPCHeatPumpMainComponent Atlantic Excellia A.I. TRI 16 without room thermostat

Error while setting up overkiz platform for climate
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 358, in _async_setup_platform
    await asyncio.gather(*pending)
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 609, in async_add_entities
    for entity in new_entities:
  File "/usr/src/homeassistant/homeassistant/components/overkiz/climate.py", line 38, in <genexpr>
    WIDGET_AND_CONTROLLABLE_TO_CLIMATE_ENTITY[device.widget][
  File "/usr/src/homeassistant/homeassistant/components/overkiz/climate_entities/atlantic_pass_apc_heating_zone.py", line 103, in __init__
    self.temperature_device = self.executor.linked_device(
                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/overkiz/executor.py", line 45, in linked_device
    return self.coordinator.data[f"{self.base_device_url}#{index}"]
           ~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'io://xxxx-xxxx-4669/2257636#9'

What version of Home Assistant Core has the issue?

core-2024.3.0

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Container

Integration causing the issue

overkiz

Link to integration documentation on our website

https://www.home-assistant.io/integrations/overkiz

Diagnostics information

config_entry-overkiz-33ec00e06d7e5a30aad534a06e5e2ec5.json

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 4 months ago

Hey there @imicknl, @vlebourl, @tetienne, @nyrodev, @tronix117, mind taking a look at this issue as it has been labeled with an integration (overkiz) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `overkiz` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign overkiz` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


overkiz documentation overkiz source (message by IssueLinks)

Tronix117 commented 4 months ago

Thanks for your investigation, I'll handle this issue. Quick question, was your device supported with the previous version of HomeAssistant ?

Note: does not seem to be a regression in core-2024.3.0, it was previously handled by atlantic_pass_apc_heating_zone.py and it's still the case.

yllar commented 4 months ago

Not with the core overkiz. So far i'm using the custom cozytouch component.