Enable config flow for html5

alexyao2015 commented 2 months ago

Breaking change

Proposed change

This converts HTML5 to use config flow. In the process, this also removes the need for the user to manually obtain a VAPID key as it is now automatically generated.

This also removes the long deprecated GCM configuration method.

Type of change

[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New integration (thank you!)
[x] New feature (which adds functionality to an existing integration)
[ ] Deprecation (breaking change to happen in the future)
[ ] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/31805

Checklist

[x] The code change is tested and works locally.
[x] Local tests pass. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist
[x] I have followed the perfect PR recommendations
[x] The code has been formatted using Ruff (ruff format homeassistant tests)
[x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[x] The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
[x] New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
[ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
[ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

[ ] I have reviewed two other open pull requests in this repository.

alexyao2015 commented 3 weeks ago

The get_service call just got converted to an async function. https://github.com/home-assistant/core/pull/116068

bdraco commented 3 weeks ago

Its not thread-safe to call hass.http.register_view or hass.services.async_register in the executor. It should have been an an async function all along

sdb9696 commented 3 weeks ago

Its not thread-safe to call hass.http.register_view or hass.services.async_register in the executor. It should have been an an async function all along

Ah ok, my bad I didn't know that, thanks @bdraco. This is all good from me, thanks @alexyao2015!

bdraco commented 6 days ago

testing....

bdraco commented 6 days ago

dismiss service is there

bdraco commented 6 days ago

notify.html5 service is missing though

alexyao2015 commented 3 days ago

Issue is fixed

bdraco commented 3 days ago

I did some testing. Some observations:

After enabling the notifications, I still have to restart for the new service to appear
Sending a notification via the new service after restart didn't work in firefox or chrome

home-assistant / core