home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
69.03k stars 28.28k forks source link

Fix nibe_heatpump climate for models without cooling support #114599

Closed tizianodeg closed 1 week ago

tizianodeg commented 1 month ago

Breaking change

Proposed change

This fixes #114548 to show the Climate Sensor also for Nibe heat pumps that do not support cooling

Type of change

Additional information

Checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

To help with the load of incoming pull requests:

home-assistant[bot] commented 1 month ago

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] commented 1 month ago

Hey there @elupus, mind taking a look at this pull request as it has been labeled with an integration (nibe_heatpump) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `nibe_heatpump` can trigger bot actions by commenting: - `@home-assistant close` Closes the pull request. - `@home-assistant rename Awesome new title` Renames the pull request. - `@home-assistant reopen` Reopen the pull request. - `@home-assistant unassign nibe_heatpump` Removes the current integration label and assignees on the pull request, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.
tizianodeg commented 2 weeks ago

Hey @elupus, I have rebased and added a test for the warning setting temperature with Havac.Cool mode if not supported. If you have some comments feel free to reach me.

Best, Tiziano