home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.38k stars 30.64k forks source link

snapcast.join service set wrong command in UI mode #115430

Open jimbovp opened 6 months ago

jimbovp commented 6 months ago

The problem

When using the service snapcast.join in UI mode (in Developer tools or in a script), the service isn't working correctly. Switching to YAML mode shows that an "entity_id" is erroneously added in the service, which causes the service call to fail:

service: snapcast.join
data:
master: media_player.7d3aa1ca_snapcastclient_snapcast_client
  entity_id:  <---
    entity_id: media_player.kachelberry_snapcast_client_2

Correcting the YAML to the correct format as follows, the service can be called:

service: snapcast.join
data:
  master: media_player.7d3aa1ca_snapcastclient_snapcast_client
  entity_id: media_player.kachelberry_snapcast_client_2

What version of Home Assistant Core has the issue?

core-2024.4.3

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

snapcast

Link to integration documentation on our website

https://www.home-assistant.io/integrations/snapcast/

Diagnostics information

No response

Example YAML snippet

service: snapcast.join
data:
master: media_player.7d3aa1ca_snapcastclient_snapcast_client
  entity_id:  <---
    entity_id: media_player.kachelberry_snapcast_client_2

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 6 months ago

Hey there @luar123, mind taking a look at this issue as it has been labeled with an integration (snapcast) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `snapcast` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign snapcast` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


snapcast documentation snapcast source (message by IssueLinks)

bradley-rose commented 4 months ago

Confirming this issue as well. It defaults to:

service: snapcast.join
data:
master: media_player.<Master>
  entity_id:  <---
    entity_id: media_player.<Subscriber>

It should present as:

service: snapcast.join
data:
  master: media_player.<Master>
  entity_id:
    - media_player.<Subscriber>
issue-triage-workflows[bot] commented 1 month ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

luar123 commented 1 month ago

Not stale