home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
71.72k stars 29.98k forks source link

Unable to add integration #115825

Closed XalaTheShepard closed 2 months ago

XalaTheShepard commented 5 months ago

The problem

After a reload of the backup of the same day, the geocaching integration was unavailable. After delering the integration, I tried to add it again ( used to work always). When trying to add the integration, I receive the link to the website of geocaching and allow the share of information. After clicking allow, I receive the error message 'an error has occurred ' with the picture of Nabu Casa and HA. Result: I am unable to add the integration already for more than a week.

What version of Home Assistant Core has the issue?

2024.4.3

What was the last working version of Home Assistant Core?

Below 2024.4.3

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Geocaching

Link to integration documentation on our website

https://www.home-assistant.io/integrations/geocaching/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 5 months ago

Hey there @sholofly, @reinder83, mind taking a look at this issue as it has been labeled with an integration (geocaching) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `geocaching` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign geocaching` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


geocaching documentation geocaching source (message by IssueLinks)

XalaTheShepard commented 5 months ago

Screenshot_2024-04-18-23-28-18-511_com android chrome

XalaTheShepard commented 5 months ago

Please find above the image of the error message

gracar2002 commented 5 months ago

+1 with that issue, didn't restore from back-up but noticed it was no longer available. Assumed the token had expired so removed integration and now when I re-add getting the above. Notice that the redirect URL ends ...redirect_uri=https://account-link.nabucasa.com/authorize_callback. I don't have a Nabu Casa account.

reinder83 commented 5 months ago

+1 with that issue, didn't restore from back-up but noticed it was no longer available. Assumed the token had expired so removed integration and now when I re-add getting the above. Notice that the redirect URL ends ...redirect_uri=https://account-link.nabucasa.com/authorize_callback. I don't have a Nabu Casa account.

You dont need nabu casa for that, they just facilitate the OAuth for us, since it needs to be whitelisted at the geocaching API

gracar2002 commented 5 months ago

+1 with that issue, didn't restore from back-up but noticed it was no longer available. Assumed the token had expired so removed integration and now when I re-add getting the above. Notice that the redirect URL ends ...redirect_uri=https://account-link.nabucasa.com/authorize_callback. I don't have a Nabu Casa account.

You dont need nabu casa for that, they just facilitate the OAuth for us, since it needs to be whitelisted at the geocaching API

My apologies, please let me know if you need logs of anything and I'll do what I can to assist.

reinder83 commented 5 months ago

Yeah logs files could be useful, maybe @Sholofly can have a look at what is happening? I currently don't have my dev setup for the integration

gracar2002 commented 5 months ago

I'll have a dig but there's nothing in my Home Assistant logs

Sholofly commented 5 months ago

Groundspeak (the company behind Geocaching) changed their API. They're requiring PKCE now. NC is not prepared for that.

Sholofly commented 4 months ago

@balloob Hi Paulus, since we've communicated about this before i'm adressing you. Can you help me figuring out what has to happen to make the integration work again? Since the authorization part goes via Nabu Casa I'm not sure the solution lies (partly) within the package / integration.

slartibartfass commented 4 months ago

+1 for fixing this issue

Disane87 commented 3 months ago

Same issue on my end. Wanted to add the integratiom but that didn't work

pksoft585 commented 3 months ago

Same issue on my HA.

bemble commented 3 months ago

Hi @XalaTheShepard, thanks for reporting the issue. We have to handle PKCE flow indeed. We're on it 👍

bemble commented 2 months ago

PKCE has been implemented in our services, it works now:

image
Disane87 commented 2 months ago

Works perfectly, thank you!

Sholofly commented 2 months ago

Yeah, good job Thanks @bemble !

bemble commented 2 months ago

Yeah, good job Thanks @bemble !

Thx @ludeeus for it ;)

Sholofly commented 2 months ago

Thanks @ludeeus !

slartibartfass commented 2 months ago

Thanks.