home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
68.78k stars 28.11k forks source link

Start zwave_js tasks eagerly #116171

Closed bdraco closed 1 week ago

bdraco commented 1 week ago

Proposed change

This is an attempt to reduce the races in #116136 but since I cannot reproduce that issue I am not sure if it will help

Type of change

Additional information

Checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

To help with the load of incoming pull requests:

home-assistant[bot] commented 1 week ago

Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration (zwave_js) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `zwave_js` can trigger bot actions by commenting: - `@home-assistant close` Closes the pull request. - `@home-assistant rename Awesome new title` Renames the pull request. - `@home-assistant reopen` Reopen the pull request. - `@home-assistant unassign zwave_js` Removes the current integration label and assignees on the pull request, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.
MartinHjelmare commented 1 week ago

I think we should finish https://github.com/home-assistant/core/pull/107635 instead.

bdraco commented 1 week ago

closing this one in favor of #107635

happy to take another look at it. I've been skipping over it when doing reviews since its still marked as draft (and currently has a conflict)

MartinHjelmare commented 1 week ago

Yeah, I need to add tests.