home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
70.06k stars 29.13k forks source link

Water Heater Leak Shutoff Valve Sensor Showing Closed instead of Open #116262

Open izzletodasmizzle opened 2 months ago

izzletodasmizzle commented 2 months ago

The problem

I noticed an issue with the Econet integration where the sensor for the built in leak detection is showing "closed" when the valve is actually in the "open" position. It looks like these are reversed. Unless this is looked at by the sensor as a circuit therefore closed means it is completing the connection?

This is using a Rheem ProTerra hybrid water heater.

Screenshot_2024-04-26-11-58-34-70_c3a231c25ed346e59462e84656a70e50

What version of Home Assistant Core has the issue?

2024.4.3

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Rheem Econet Products

Link to integration documentation on our website

https://www.home-assistant.io/integrations/econet/#sensor

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 2 months ago

Hey there @w1ll1am23, mind taking a look at this issue as it has been labeled with an integration (econet) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `econet` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign econet` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


econet documentation econet source (message by IssueLinks)

w1ll1am23 commented 2 months ago

So the backing library for this does a check for if the @VALVE value is set to "0" to indicate if its open.

The HA code returns true for the binary sensor state if the library says its open. So I think this is working correctly? Could be the API has changed. Unfortunately I don't have a way to test this anymore.

@izzletodasmizzle if you enable debug logging for pyeconet in your config and provide those here (remove any personal info) we should be able to confirm if something changes.

w1ll1am23 commented 2 months ago

Side note @izzletodasmizzle if you aren't aware there is a fully local control esphome project for water heaters that would let you move off of this integration.

https://github.com/esphome-econet/esphome-econet

mash55 commented 2 months ago

Mine is also on CLOSED (even though its open). I spilled some water on the sensor to trigger an ALARM. Rheem valved closed as expected but Homeassistant did not change at all. New HA user running: Core 2024.4.4 Supervisor 2024.04.0 Operating System 12.2 Frontend 20240404.2

Since I am all new to this I can't comment whether is worked in other versions.

image

Image above show NO changes during the time the valve was closed.

faultymonk commented 2 months ago

Image above show NO changes during the time the valve was closed.

I'm not sure that the status reported by the cloud integration is to be trusted. For instance for me, the running sensor or running state via the econet integration would frequently say that it's running (matches the status from the Rheem app). However, the waterheater itself, or the status obtained from esphome-econet via the debug serial port would accurate reflect the running status (i.e. not running).

Also, the Shutoff Valve Sensor status also says Closed instead of Open for me in the integration.

faultymonk commented 2 months ago

Side note @izzletodasmizzle if you aren't aware there is a fully local control esphome project for water heaters that would let you move off of this integration.

Please note that the shutoff valve status reporting is not yet supported via esphome-econet.

izzletodasmizzle commented 2 months ago

Image above show NO changes during the time the valve was closed.

I'm not sure that the status reported by the cloud integration is to be trusted. For instance for me, the running sensor or running state via the econet integration would frequently say that it's running (matches the status from the Rheem app). However, the waterheater itself, or the status obtained from esphome-econet via the debug serial port would accurate reflect the running status (i.e. not running).

Also, the Shutoff Valve Sensor status also says Closed instead of Open for me in the integration.

Thanks for confirming. I ordered the required ESP items to just go with the locally hosted option in HA. Also good to know that the esphome integration doesn't currently work with the leak sensor.

I'm also having problems with the app / cloud integration not accurately updating the current State as you mentioned.