home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
70.57k stars 29.48k forks source link

Jewish Calendar Integration gets Tzeit time wrong #116322

Closed gedaliahknizhnik closed 3 months ago

gedaliahknizhnik commented 3 months ago

The problem

I have integrations set to flash a chandelier when the Issur Melacha sensor changes state, so that I know when holidays start and end. This works great and consistently goes off at the correct time. In order to tell the transition from one day of yom-tov to the next, I have it also set to go off at Tzeit HaKochavim when Issur Melacha is on - this integration tends to go off abbout 10-15 minutes too early. For example, the log for today has Tzeit at 8:27 PM for my location (Washington DC), but MyZmanim has it as 8:41 PM.

What's going on?

What version of Home Assistant Core has the issue?

core-2024.4.3

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Container

Integration causing the issue

jewish_calendar

Link to integration documentation on our website

https://www.home-assistant.io/integrations/jewish_calendar/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 3 months ago

Hey there @tsvi, mind taking a look at this issue as it has been labeled with an integration (jewish_calendar) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `jewish_calendar` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign jewish_calendar` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


jewish_calendar documentation jewish_calendar source (message by IssueLinks)

tsvi commented 3 months ago

There are multiple opinions regarding tzeit hakochavim. The one in use by the integration is defined as the sun setting 6 degrees past the horizon, which is the value in use by most rabbinical opinions regarding tzeit when considering Kriat sham, maariv, sfirat haomer etc. On shabbes and yom tov, the majority opinion is to use 8.5 degrees past the horizon, so as not to transgress torah prohibitions. That's the time you see in MyZmanim (and is in use by the issue melacha sensor). (Compare tzeit on a "regular" day, you should get a result similar to the integration).

But definitely a good suggestion for a feature request to add support for both "versions" of tzeit.

Closing, as feature requests are not supposed to go here.

@home-assistant close

tsvi commented 3 months ago

@home-assistant close