home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.97k stars 31.01k forks source link

device class nitrous_oxide incorrectly named, should be nitrogen_oxides #116594

Closed totalamateurhour closed 6 months ago

totalamateurhour commented 6 months ago

The problem

The device class nitrous_oxide is defined as "Concentration of Nitrous Oxide in µg/m³" in the Sensor documentation and it follows these two classes

Nitrous Oxide is N2O, nicknamed "laughing gas", per Wikipedia.

Rather than for N2O, it makes more sense that the device class was intended for measuring the combination of the previous two gasses, or NOx, which is shorthand for nitric oxide (NO, aka nitrogen monoxide) and nitrogen dioxide (NO2), the nitrogen oxides that are most relevant for air pollution, again per Wikipedia.

The device class nitrous_oxide should be renamed nitrogen_oxides.

What version of Home Assistant Core has the issue?

2024-5

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Container

Integration causing the issue

No response

Link to integration documentation on our website

https://www.home-assistant.io/integrations/sensor/#device-class

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 6 months ago

Hey there @home-assistant/core, mind taking a look at this issue as it has been labeled with an integration (sensor) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `sensor` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign sensor` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


sensor documentation sensor source (message by IssueLinks)

MartinHjelmare commented 6 months ago

We can't rename or reclassify an existing device class. It means what it says it means.

If another device class is needed, that's a different discussion.